Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: L2 network cannot filter transactions in v24.9.0 #58

Merged
merged 6 commits into from
Jul 23, 2024

Conversation

JayT106
Copy link
Contributor

@JayT106 JayT106 commented Jul 15, 2024

Solution: backport #47

For adding the deny list addresses, requires to add in the chain env config file.

API_TX_SINK_DENY_LIST=[address 1],[address 2], ...

Note:
The command zk server will launch a deny list component by default(with an empty deny list if there is no deny list setup mentioned above)

@JayT106 JayT106 requested a review from thomas-nguy July 15, 2024 19:02
@JayT106 JayT106 self-assigned this Jul 15, 2024
@JayT106 JayT106 requested a review from calvinaco July 15, 2024 19:02
@JayT106 JayT106 changed the title Problem: L2 network cannot filter transactions Problem: L2 network cannot filter transactions in v24.9.0 Jul 16, 2024
@JayT106 JayT106 changed the base branch from cronos-v24.9.0 to testnet-v24.9.0 July 19, 2024 13:40
@thomas-nguy
Copy link
Member

thomas-nguy commented Jul 21, 2024

are the unit tests building?

@JayT106
Copy link
Contributor Author

JayT106 commented Jul 22, 2024

are the unit tests building?

Will try to add one. the integration is a little bit different than v24.2.
I've tested it against local net setup (with zksync-core-v24.9.0 codebase).

@thomas-nguy
Copy link
Member

its okay for the unit test but just make sure it does not break the build

@thomas-nguy
Copy link
Member

I'm having a build issue with cargo test

error[E0423]: expected value, found struct `MasterPoolSinkLayer`
   --> core/node/node_framework/examples/main_node.rs:218:29
    |
218 |         self.node.add_layer(MasterPoolSinkLayer);
    |                             ^^^^^^^^^^^^^^^^^^^
    |
   ::: /Users/thomasnguy/Documents/zksync/v24.9.0/core/node/node_framework/src/implementations/layers/web3_api/tx_sink/master_pool_sink.rs:16:1
    |
16  | pub struct MasterPoolSinkLayer {
    | ------------------------------ `MasterPoolSinkLayer` defined here

For more information about this error, try `rustc --explain E0423`.

@JayT106
Copy link
Contributor Author

JayT106 commented Jul 22, 2024

I'm having a build issue with cargo test

error[E0423]: expected value, found struct `MasterPoolSinkLayer`
   --> core/node/node_framework/examples/main_node.rs:218:29
    |
218 |         self.node.add_layer(MasterPoolSinkLayer);
    |                             ^^^^^^^^^^^^^^^^^^^
    |
   ::: /Users/thomasnguy/Documents/zksync/v24.9.0/core/node/node_framework/src/implementations/layers/web3_api/tx_sink/master_pool_sink.rs:16:1
    |
16  | pub struct MasterPoolSinkLayer {
    | ------------------------------ `MasterPoolSinkLayer` defined here

For more information about this error, try `rustc --explain E0423`.

Ah, okay, it's in example code.
fixed...

@thomas-nguy
Copy link
Member

lgtm

@thomas-nguy thomas-nguy merged commit c339251 into testnet-v24.9.0 Jul 23, 2024
4 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants