-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: L2 network cannot filter transactions in v24.9.0 #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JayT106
changed the title
Problem: L2 network cannot filter transactions
Problem: L2 network cannot filter transactions in v24.9.0
Jul 16, 2024
thomas-nguy
reviewed
Jul 21, 2024
are the unit tests building? |
Will try to add one. the integration is a little bit different than v24.2. |
its okay for the unit test but just make sure it does not break the build |
I'm having a build issue with cargo test
|
Ah, okay, it's in example code. |
lgtm |
thomas-nguy
pushed a commit
that referenced
this pull request
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution: backport #47
For adding the deny list addresses, requires to add in the chain env config file.
Note:
The command
zk server
will launch a deny list component by default(with an empty deny list if there is no deny list setup mentioned above)