Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: missing GKMSSigner feature #91

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

JayT106
Copy link
Contributor

@JayT106 JayT106 commented Oct 24, 2024

Cherry-picking PR #78

@JayT106 JayT106 changed the base branch from cronos-v24.23.0 to cronos-v25.0.0 October 24, 2024 03:03
@JayT106 JayT106 assigned JayT106 and unassigned JayT106 Oct 24, 2024
Copy link
Member

@thomas-nguy thomas-nguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some unnecessary indent change but lgtm

Is it possible to test quickly gkms signer before merging?

@JayT106
Copy link
Contributor Author

JayT106 commented Oct 24, 2024

There are some unnecessary indent change but lgtm

Is it possible to test quickly gkms signer before merging?

For sure.

@JayT106
Copy link
Contributor Author

JayT106 commented Oct 24, 2024

@thomas-nguy I got an error when doing zk init, is there zksync contract we have to patch?

2024-10-24T19:08:17.708913Z  INFO NamedFuture{name=node_storage_initializer}: zksync_node_storage_init: Performing genesis initialization
2024-10-24T19:08:17.767325Z ERROR zksync_node_framework::service: Task oneshot_runner failed: Oneshot task node_storage_initializer failed

Caused by:
    Base system contracts mismatched: From Config BaseSystemContractsHashes { bootloader: 0x010008c37ecadea8b003884eb9d81fdfb7161b3b309504e5318f15da19c500d8, default_aa: 0x0100055da70d970f98ca4677a4b2fcecef5354f345cc5c6d13a78339e5fd87a9, evm_emulator: None }, Calculated : BaseSystemContractsHashes { bootloader: 0x010008c3be57ae5800e077b6c2056d9d75ad1a7b4f0ce583407961cc6fe0b678, default_aa: 0x0100055dba11508480be023137563caec69debc85f826cb3a4b68246a7cabe30, evm_emulator: None }

BTW, I tested the code can connect to the gkms_server and retrieve the public addressof the signer.

@JayT106 JayT106 self-assigned this Oct 24, 2024
@thomas-nguy
Copy link
Member

Thanks @JayT106

I have created a PR to fix the configuration issue
#95

Can you help me and sign your commit? The merge button is blocked

@JayT106 JayT106 force-pushed the jt/v25.0.0-gkms-signer-cherry-pick branch from ba765a9 to 778d76e Compare October 25, 2024 15:44
@thomas-nguy thomas-nguy merged commit ce149aa into cronos-v25.0.0 Oct 25, 2024
11 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants