Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix mips #1394

Merged
merged 1 commit into from
Dec 23, 2023
Merged

fix mips #1394

merged 1 commit into from
Dec 23, 2023

Conversation

Emilgardis
Copy link
Member

@Emilgardis Emilgardis commented Dec 23, 2023

No description provided.

@Emilgardis Emilgardis requested a review from a team as a code owner December 23, 2023 17:19
@Emilgardis Emilgardis added the no changelog A valid PR without changelog (no-changelog) label Dec 23, 2023
@Emilgardis
Copy link
Member Author

@Emilgardis
Copy link
Member Author

Emilgardis commented Dec 23, 2023

mips64-unknown-linux-muslabi64 and mips64el-unknown-linux-muslabi64 both fail with similar error, not sure why the crt is not found

exec mips64-linux-musl-gcc crt1.o crti.o crtbegin.o /tmp/rustcdYwR8P/symbols.o /target/mips64-unknown-linux-muslabi64/debug/deps/hello-5bf60b377dad2126.hello.e88678c3ba72d42f-cgu.0.rcgu.o /target/mips64-unknown-linux-muslabi64/debug/deps/hello-5bf60b377dad2126.2dfyjk85w6hfes7y.rcgu.o -Wl,--as-needed -L /target/mips64-unknown-linux-muslabi64/debug/deps -L /target/debug/deps -L /home/runner/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/mips64-unknown-linux-muslabi64/lib -Wl,-Bstatic /target/mips64-unknown-linux-muslabi64/debug/deps/libstd-d3b77a59fc4a4692.rlib /target/mips64-unknown-linux-muslabi64/debug/deps/libpanic_unwind-bd17e36809258b66.rlib /target/mips64-unknown-linux-muslabi64/debug/deps/libobject-c324cc8ae5c8b0fd.rlib /target/mips64-unknown-linux-muslabi64/debug/deps/libmemchr-d2297200f09ebffb.rlib /target/mips64-unknown-linux-muslabi64/debug/deps/libaddr2line-df98f44c6c9bf083.rlib /target/mips64-unknown-linux-muslabi64/debug/deps/libgimli-ef99e9f6f07d70f7.rlib /target/mips64-unknown-linux-muslabi64/debug/deps/librustc_demangle-fdf113e05b6bda0e.rlib /target/mips64-unknown-linux-muslabi64/debug/deps/libstd_detect-00376d04620172bb.rlib /target/mips64-unknown-linux-muslabi64/debug/deps/libhashbrown-ae72689e36c6c38f.rlib /target/mips64-unknown-linux-muslabi64/debug/deps/librustc_std_workspace_alloc-484259eb32fcf99b.rlib /target/mips64-unknown-linux-muslabi64/debug/deps/libminiz_oxide-ad0f123872cb76d5.rlib /target/mips64-unknown-linux-muslabi64/debug/deps/libadler-14be33b389d9a409.rlib /target/mips64-unknown-linux-muslabi64/debug/deps/libunwind-60ed854b6acd3f5d.rlib -lunwind /target/mips64-unknown-linux-muslabi64/debug/deps/libcfg_if-da28e98563d4d896.rlib /target/mips64-unknown-linux-muslabi64/debug/deps/liblibc-68f0059b243ac4f6.rlib -lc /target/mips64-unknown-linux-muslabi64/debug/deps/liballoc-1015b8740106b8ee.rlib /target/mips64-unknown-linux-muslabi64/debug/deps/librustc_std_workspace_core-115450f57a6d633a.rlib /target/mips64-unknown-linux-muslabi64/debug/deps/libcore-55d11291351dd73f.rlib /target/mips64-unknown-linux-muslabi64/debug/deps/libcompiler_builtins-a42345a970f32ae4.rlib -Wl,-Bdynamic -Wl,--eh-frame-hdr -Wl,-z,noexecstack -nostartfiles -L /home/runner/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/mips64-unknown-linux-muslabi64/lib -L /home/runner/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/mips64-unknown-linux-muslabi64/lib/self-contained -o /target/mips64-unknown-linux-muslabi64/debug/deps/hello-5bf60b377dad2126 -Wl,--gc-sections -static -no-pie -Wl,-z,relro,-z,now -nodefaultlibs crtend.o crtn.o
          mips64-linux-musl-gcc: error: crt1.o: No such file or directory
          mips64-linux-musl-gcc: error: crti.o: No such file or directory
          mips64-linux-musl-gcc: error: crtbegin.o: No such file or directory
          mips64-linux-musl-gcc: error: crtend.o: No such file or directory
          mips64-linux-musl-gcc: error: crtn.o: No such file or directory

I can't find any existing issue for this, all the linker does is workaround rust-lang/compiler-builtins#483 which is not a problem for us in CI

@Emilgardis Emilgardis added the no-ci-targets PRs that do not affect any cross-compilation targets. label Dec 23, 2023
@Emilgardis
Copy link
Member Author

#1346 didn't help :/

@Emilgardis Emilgardis enabled auto-merge December 23, 2023 19:03
@Emilgardis Emilgardis added this pull request to the merge queue Dec 23, 2023
@Emilgardis Emilgardis removed this pull request from the merge queue due to a manual request Dec 23, 2023
@Emilgardis Emilgardis enabled auto-merge December 23, 2023 19:17
@Emilgardis Emilgardis added this pull request to the merge queue Dec 23, 2023
Merged via the queue into main with commit 10bfcb9 Dec 23, 2023
21 checks passed
@Emilgardis Emilgardis deleted the fix-mips branch December 23, 2023 19:33
github-merge-queue bot pushed a commit that referenced this pull request Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog A valid PR without changelog (no-changelog) no-ci-targets PRs that do not affect any cross-compilation targets.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant