Implement Worker::is_same_as #1103
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taiki-e
reviewed
Apr 25, 2024
| /// assert!(!w_1.is_same_as(&s_2)); | ||
| /// assert!(!w_2.is_same_as(&s_1)); | ||
| /// ``` | ||
| pub fn is_same_as(&self, stealer: &Stealer<T>) -> bool { |
There was a problem hiding this comment.
I don't feel this method name is easy to understand, but I'm not sure what the good name would be.
There was a problem hiding this comment.
Not sure if Worker::ptr_eq is better. I can't seem to come up with a better name here either.
taiki-e
added
crossbeam-deque
S-waiting-on-bikeshed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it's not possible to tell if a Worker and a Stealer point to the same underlying queue. This make it difficult to tell which stealer to remove from a list and you have a local Worker on hand, or skip stealing from when given a global list of stealers. The implementation just forwards to Arc::ptr_eq on the inner buffer. Added a doctest as well.