Merge pull request #21 from ezgidemirel/add-nil-checks

Fix nil pointer crashes with wrong input

fn_test.go

@@ -94,6 +94,49 @@ func TestRunFunction(t *testing.T) {
 				},
 			},
 		},
+		"WrongInlineInput": {
+			reason: "The Function should return a fatal result if there is no inline template provided",
+			args: args{
+				req: &fnv1beta1.RunFunctionRequest{
+					Input: resource.MustStructObject(
+						&v1beta1.GoTemplate{
+							Source: v1beta1.InlineSource,
+						}),
+				},
+			},
+			want: want{
+				rsp: &fnv1beta1.RunFunctionResponse{
+					Meta: &fnv1beta1.ResponseMeta{Ttl: durationpb.New(response.DefaultTTL)},
+					Results: []*fnv1beta1.Result{
+						{
+							Severity: fnv1beta1.Severity_SEVERITY_FATAL,
+							Message:  "invalid function input: inline.template should be provided",
+						},
+					},
+				},
+			},
+		},
+		"WrongFileSystemInput": {
+			args: args{
+				req: &fnv1beta1.RunFunctionRequest{
+					Input: resource.MustStructObject(
+						&v1beta1.GoTemplate{
+							Source: v1beta1.FileSystemSource,
+						}),
+				},
+			},
+			want: want{
+				rsp: &fnv1beta1.RunFunctionResponse{
+					Meta: &fnv1beta1.ResponseMeta{Ttl: durationpb.New(response.DefaultTTL)},
+					Results: []*fnv1beta1.Result{
+						{
+							Severity: fnv1beta1.Severity_SEVERITY_FATAL,
+							Message:  "invalid function input: fileSystem.dirPath should be provided",
+						},
+					},
+				},
+			},
+		},
 		"NoResourceNameAnnotation": {
 			reason: "The Function should return a fatal result if the cd does not have a composition-resource-name annotation",
 			args: args{

template.go

@@ -48,6 +48,10 @@ func (is *InlineSource) GetTemplates() string {
 }
 
 func newInlineSource(in *v1beta1.GoTemplate) (*InlineSource, error) {
+	if in.Inline == nil || in.Inline.Template == "" {
+		return nil, errors.New("inline.template should be provided")
+	}
+
 	return &InlineSource{
 		Template: in.Inline.Template,
 	}, nil
@@ -59,6 +63,10 @@ func (fs *FileSource) GetTemplates() string {
 }
 
 func newFileSource(in *v1beta1.GoTemplate) (*FileSource, error) {
+	if in.FileSystem == nil || in.FileSystem.DirPath == "" {
+		return nil, errors.New("fileSystem.dirPath should be provided")
+	}
+
 	d := in.FileSystem.DirPath
 
 	tmpl, err := readTemplates(d)