Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the Input type to GoTemplate #15

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

negz
Copy link
Member

@negz negz commented Nov 3, 2023

Description of your changes

I just realised the examples were updated but the actual kind wasn't. This doesn't matter very much because right now nothing validates the kind, so you could use whatever apiVersion and kind you wanted as long as the struct schemas matched. :)

This does fix the Marketplace entry though, which is a little confusing because it lists the input kind as 'Input' when the examples here are all 'GoTemplate': https://marketplace.upbound.io/functions/crossplane-contrib/function-go-templating/v0.2.1

I have:

I just realised the examples were updated but the actual kind wasn't.
This doesn't matter very much because right now nothing validates the
kind, so you could use whatever apiVersion and kind you wanted as long
as the struct schemas matched. :)

This does fix the Marketplace entry though, which is a little confusing
because it lists the input kind as 'Input' when the examples here are
all 'GoTemplate'.

Signed-off-by: Nic Cope <[email protected]>
@negz
Copy link
Member Author

negz commented Nov 3, 2023

@ezgidemirel @turkenh if you approve and merge this, could you please cut a v0.2.2 release to update the Marketplace listing?

The process is pretty straightforward:

  1. Create and merge a PR to cherry-pick this commit into the release-0.2 branch.
  2. Create a new v0.2.2 release using the web UI, from the release-0.2 branch. GItHub will automatically create the tag.
  3. Run the CI workflow against the v0.2.2 tag, and tell it to tag the package as v0.2.2

Once CI runs you should see v0.2.2 at https://marketplace.upbound.io/functions.

Copy link
Collaborator

@ezgidemirel ezgidemirel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ezgidemirel ezgidemirel merged commit 680f061 into crossplane-contrib:main Nov 3, 2023
6 checks passed
@negz negz deleted the temple branch November 3, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants