Crossplane resources generated by k8s-infra-gen #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The intent of these is primarily to begin some debate/discussion about their shape and what people like/don't like. These are not ready for prime time! Signed-off-by: Matthew Christopher <[email protected]>
matthchr
force-pushed
the
genreated-example
branch
from
71fe213 to
b7800f1
Compare
|
@matthchr Could you share your "crossplane-hacking" git repo (if it still exists) ? |
|
This has been merged into master of k8s-infra-gen. None of the generated resources are checked in currently, but you can generate them by running: These resources will need an adapter written so that they satisfy the required Crossplane interface, which we haven't yet done. The adapter will need to look something like this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are not ready for prime time!
I am not even sure that it makes sense to merge these to master.
@kasey suggested I send a PR though based on what we have so far. I believe the idea is to start some discussion as to the shape of resources and what more work we still have to do to get things working. It's up to you if you want to merge this at all, since obviously right now it's not "doing" anything.
This was generated with a private build of k8s-infra-gen based on my crossplane-hacking branch, so it's important to understand that the tool that produced this isn't even merged to master of k8s-infra yet.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
It hasn't! (see above for other reasons why you may not want to merge it).