-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Application, ServicePrincipal, Role, Group, RoleAssignment support #297
base: master
Are you sure you want to change the base?
Add Application, ServicePrincipal, Role, Group, RoleAssignment support #297
Conversation
e109a80
to
07e20dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @vaspahomov,
Thank you for the PR. I have left some comments. Could you please also mention in the PR description how you tested these new MRs?
} | ||
|
||
const ( | ||
appCredsValidYears = 5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we make this part of the spec
(i.e., make it a parameter)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think better to implement creds autoupdates, I added todo note about this
d996d20
to
0f1a5c5
Compare
Signed-off-by: vaspahomov <[email protected]>
0f1a5c5
to
0288a64
Compare
Hi! @ulucinar |
Any updates when this PR is getting merged? |
Hi @vaspahomov, |
Signed-off-by: vaspahomov <[email protected]>
Hi @ulucinar, |
Thank you very much @vaspahomov for bearing with us on this PR. Together with @sergenyalcin, we took another pass over the PR. Among the resolved issues, I did not fully understand the logic here: Could you please shed some light on these probably with comments? |
Do I understand correctly that this change uses the Active Directory Graph API for communication with Azure? If that is the case it should be noted that those API:s are deprecated and support will be removed on June 30th, 2022. |
we are in need of this |
Description of your changes
Add support of:
This patch allow:
I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested