doc(values): Be more precise about possibilities how to set values #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Schroeder (external expert on behalf of DB Netz) <[email protected]>
schroeder-paul
changed the title
turkenh
reviewed
May 9, 2023
apis/release/v1beta1/types.go
Outdated
| Value string `json:"value,omitempty"` | ||
| ValueFrom *ValueFromSource `json:"valueFrom,omitempty"` | ||
| } | ||
|
|
||
| // ValuesSpec defines the Helm value overrides spec for a Release | ||
| type ValuesSpec struct { | ||
| // Values literals (precedence order: Values < ValuesFrom < Set) |
There was a problem hiding this comment.
Suggested change
| // Values literals (precedence order: Values < ValuesFrom < Set) | |
| // Values literals (precedence order: ValuesFrom < Values < Set) |
I think this should be like the above:
There was a problem hiding this comment.
@schroeder-paul this comment was resolved, but, I see it not resolved on the PR. Did you forget to push?
Signed-off-by: Paul Schroeder (external expert on behalf of DB Netz) <[email protected]>
schroeder-paul
force-pushed
the
doc/usage-values
branch
from
7730098
to
81ed47c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Added some info about how the different was to se the values interact. Especially the precedence order.
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
No functional changes were made.