Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loading auth keys from secrets was incorrectly removed in v0.5 during the conversion to upjet. This was associated, incorrectly, with the deprecation of provider configuration via environment variables which suggested a
main.tf.json
was the approach to take for provider secret configuration.Using a fields in a secret is still the common recommended approach:
There are some providers that support external configuration: https://github.com/crossplane/upjet/blob/main/docs/design-doc-provider-identity-based-auth.md
This change is necessary to get authentication working:
Description of your changes
Fixes #
I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested