Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restore auth keys in secrets #33

Merged
merged 1 commit into from
Oct 26, 2023
Merged

fix: restore auth keys in secrets #33

merged 1 commit into from
Oct 26, 2023

Conversation

displague
Copy link
Collaborator

@displague displague commented Oct 26, 2023

Loading auth keys from secrets was incorrectly removed in v0.5 during the conversion to upjet. This was associated, incorrectly, with the deprecation of provider configuration via environment variables which suggested a main.tf.json was the approach to take for provider secret configuration.

Using a fields in a secret is still the common recommended approach:

There are some providers that support external configuration: https://github.com/crossplane/upjet/blob/main/docs/design-doc-provider-identity-based-auth.md

This change is necessary to get authentication working:

Status:
  At Provider:
  Conditions:
    Last Transition Time:  2023-10-26T11:35:05Z
    Message:               observe failed: cannot run refresh: refresh failed: the provider needs to be configured with the proper credentials before it
can be used.

One of pair "client_id" - "client_secret" or "token" must be set in the provider
configuration to interact with Equinix Fabric and Network Edge services, and
"auth_token" to interact with Equinix Metal. These can also be configured using
environment variables.

Please note that while the authentication arguments are individually optional to allow
interaction with the different services independently, trying to provision the resources
of a service without the required credentials will return an API error referring to
'Invalid authentication token' or 'error when acquiring token'.

More information on the provider configuration can be found here:
https://registry.terraform.io/providers/equinix/equinix/latest/docs: 
    Reason:  ReconcileError
    Status:  False
    Type:    Synced

Description of your changes

Fixes #

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Signed-off-by: Marques Johansson <[email protected]>
@displague displague merged commit 9687c04 into main Oct 26, 2023
7 checks passed
@displague displague deleted the fix-auth branch March 27, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant