Add support for RealmEvents and Realm UserProfile #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Isabella Dix <[email protected]>
2 tasks
|
lgtm |
|
https://github.com/crossplane-contrib/provider-keycloak/releases/tag/v1.3.0 should be read to roll in a few minutes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Add support for keycloak_realm_events and keycloak_realm_user_profile
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Tested it on my local k3d instance with default keycloak (https://github.com/codecentric/helm-charts/tree/master/charts/keycloakx).
Known issue
During testing I discovered that when creating the UserProfile resource from scratch in an incorrect way (e.g. removing the attribute "username" or "email"), it is shown as synced and ready in K8s, but not actually reflected in Keycloak. This is resolved by adding the missing attribute. Then it is correctly reflected in Keycloak (and K8s). If one then applies the resource in the initial invalid state again, it is correctly shown as non-synced in K8s.
Probably an issue with the terraform provider.