Stop secrets payload from ending in the MR and resolve it when used instead #253
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Change Observer loop not resolve secret in start of loop but rather resolve the secret in the create/update/delete funcs
to not leak the secrets data in the the k8s MR object.
Fixes #223
Description of your changes
I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested
manual test locally to see that the secret is not leaking in to the MR using this manifests.
provider for testing have been started with
--sanitize-secrets