Read external ID for assume role authentication from k8s Secret #1602
+58
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #1548
I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR if necessary.Adds the
ProviderConfig
ability to define the external ID presented by third parties to access to AWS accounts via:on top of existing functionality
and if both are used, the value defined through
externalIDSecretRef
takes precedence (considered more secure).A function to read from a Kubernetes Secret was needed and seeing
ExtractSecret
incrossplane-runtime/apis/common/v1
I thought I could piggyback on that, to avoid defining another inprovider-upjet-aws
. Maybe a better way would be to allow something more generic incrossplane-runtime
(today it expects aCommonCredentialSelectors
)I don't have much Go development experience, please feel free to suggest if a better approach could be used.
Trying to run
make reviewable
takes a lot of time, can't say I passed that step.How has this code been tested
Tested in an EKS cluster where the provider is using IRSA for authentication
with
and the assumed role having a trust relationship like:
(and provider identity allowed to
sts:AssumeRole
).Similarly tested in kind with provider authentication method Secret, all testing done using dirty builds like