Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow overwrites of array fields #30

Merged
merged 3 commits into from
Jun 27, 2024

Conversation

akesser
Copy link
Collaborator

@akesser akesser commented May 16, 2024

Description of your changes

This change allows to overwrite fields in arrays. e.g. a overwriteFields entry like

  - path: spec.forProvider.certificateAuthorityConfiguration[0].subject[0].state
    value: "Berlin"
    ignore: true

will lead to the following yaml

spec:
  forProvider:
    certificateAuthorityConfiguration:
      - subject:
         -  state: Berlin

Fixes #

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Tested locally and added tests

pkg/generator/generator.go Outdated Show resolved Hide resolved
pkg/generator/generator.go Outdated Show resolved Hide resolved
pkg/generator/generator.go Outdated Show resolved Hide resolved
pkg/generator/generator.go Outdated Show resolved Hide resolved
pkg/generator/generator.go Outdated Show resolved Hide resolved
Signed-off-by: André Kesser <[email protected]>
Signed-off-by: André Kesser <[email protected]>
@haarchri haarchri merged commit e9f1f3b into crossplane-contrib:main Jun 27, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants