Update MR Section #457
Update MR Section #457
Conversation
Signed-off-by: Pete Lumbis <[email protected]>
Signed-off-by: Pete Lumbis <[email protected]>
Signed-off-by: Pete Lumbis <[email protected]>
Signed-off-by: Pete Lumbis <[email protected]>
Signed-off-by: Pete Lumbis <[email protected]>
Signed-off-by: Pete Lumbis <[email protected]>
Signed-off-by: Pete Lumbis <[email protected]>
Signed-off-by: Pete Lumbis <[email protected]>
Signed-off-by: Pete Lumbis <[email protected]>
Signed-off-by: Pete Lumbis <[email protected]>
✅ Deploy Preview for crossplane ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Pete Lumbis <[email protected]>
There was a problem hiding this comment.
deployment preview question: navigating using the left hand nav pane doesn't seem to work to jump between the different high level sections of the docs (e.g. user docs, knowledge base, contrib guide).
e.g. from https://64778c8b7c25e60008bdd3ac--crossplane.netlify.app/v1.12/concepts/providers/, the left hand nav pane has links to this for "Knowledge Base", which is broken. Looks like knowledge-base is being included in the domain of the URL:
https://64778c8b7c25e60008bdd3ac--crossplane.netlify.appknowledge-base/
There was a problem hiding this comment.
This is pretty great @plumbis, good job dude!! 💪 🙇♂️
I have a few questions and feedback, but nothing major here - I also reviewed thoroughly the 1.12 content (and import content) and assumed that the v1.11 and master branches content were essentially the same.
| @@ -3,630 +3,745 @@ title: Managed Resources | |||
| weight: 102 | |||
There was a problem hiding this comment.
meta: the right hand "on this page" TOC is long enough to scroll by default, but there's no obvious visual indication that it can be scrolled. any improvements you've already been thinking about making there?
There was a problem hiding this comment.
🤔 what browser? There should be a scrollbar
Signed-off-by: Pete Lumbis <[email protected]>
Great catch @jbw976 . This was an error in the variable used to build the docs in a "preview" context. I pushed a fix. |
Signed-off-by: Pete Lumbis <[email protected]>
Signed-off-by: Pete Lumbis <[email protected]>
Signed-off-by: Pete Lumbis <[email protected]>
Signed-off-by: Pete Lumbis <[email protected]>
Signed-off-by: Pete Lumbis <[email protected]>
This rewrites the
concepts/managed resourcesproviding more details and structure and passing Vale checks.The original content providing examples on importing existing resources with ObserveOnly has been moved out into a stand-alone KB.
Resolves #453, #272.
Signed-off-by: Pete Lumbis [email protected]