Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated delete providers command #860

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

YashxG
Copy link

@YashxG YashxG commented Jan 22, 2025

The command kubectl delete provider <provider_name> gives errors, the correct command to delete provider was kubectl delete providers <provider_name> replaced provider with providers.
I have attached the relevant screenshots.

kubectl delete provider
Screenshot 2025-01-22 at 11 50 33 AM

kubectl delete providers
Screenshot 2025-01-22 at 11 50 08 AM

Copy link

netlify bot commented Jan 22, 2025

Deploy Preview for crossplane ready!

Name Link
🔨 Latest commit e414c3d
🔍 Latest deploy log https://app.netlify.com/sites/crossplane/deploys/679094a64d7a8e00080bae6e
😎 Deploy Preview https://deploy-preview-860--crossplane.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 82 (🟢 up 8 from production)
Accessibility: 90 (🔴 down 2 from production)
Best Practices: 83 (no change from production)
SEO: 100 (no change from production)
PWA: 70 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@jbw976 jbw976 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to make this update @YashxG!

I wasn't able to reproduce the behavior, but I know that depending on what CRDs are installed in your cluster, kubectl can have different behavior for using kinds without their groups or without plurals, etc. so I think this change is reasonable 😂

Could you also please make this same edit to the other support version folders under the content dir? i.e. v1.17, v1.19, and master?

@jbw976
Copy link
Member

jbw976 commented Mar 14, 2025

Oh and please amend any commits you make to include the DCO sign-off. Info about that can be found in https://github.com/crossplane/crossplane/tree/main/contributing#certificate-of-origin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants