chore: Bump up crossplane-runtime version to v1.18.0 #113
Conversation
* Fix linting issue by bumping up build submodules to latest one * Add support for logs that introduced in v1.17.0 * Add support for metrics that introduced in v1.16.0 * Update Delete function that required changes in v1.17.0 * Bump up go version to 1.22 Signed-off-by: Chuan-Yen Chiang <[email protected]>
cychiang
force-pushed
the
chore-bump-up-crossplane-runtime-to-1-18-0
branch
from
065d84b to
b53779e
Compare
…/detail/CVE-2024-45338 issue Signed-off-by: Chuan-Yen Chiang <[email protected]>
There was a problem hiding this comment.
very cool to see the classic provider template get some attention! thank you for taking the time to do that 🙇♂️
can you provide a few more details about how you tested that these changes work OK? is there a test/dummy provider build that you used the updated template for?
also, what was your general approach to get all these updates? did you follow the model of a particular up to date provider, look at the release notes, etc.?
cmd/provider/main.go
Outdated
| @@ -126,6 +151,22 @@ func main() { | |||
| log.Info("Alpha feature enabled", "flag", features.EnableAlphaManagementPolicies) | |||
| } | |||
|
|
|||
| if *enableChangeLogs { | |||
There was a problem hiding this comment.
we may want to hold off an change log specific updates because they won't end to end until we have a real sidecar container build/published. I can't remember exactly what will happen if there's no server injected and present, but I can imagine the managed reconciler will encounter errors, or maybe even hang for periods of time.
See my note on crossplane/crossplane#5924 (comment) for more context on the need to get this sidecar gRPC server to the finish line! 😇
There was a problem hiding this comment.
Then I think I can remove this part for now, and bring it back when its ready.
There was a problem hiding this comment.
It seems like, what if in the near future, if someone enables an change log but failed to have a validate DeploymentRuntimeConfig? It seems like a potential risk, and might need to handle this from the crossplane-runtime? But I can try it out a bit and see what would happened... 🤔
| package version | ||
|
|
||
| // Version will be overridden with the current version at build time using the -X linker flag | ||
| var Version = "0.0.0" |
There was a problem hiding this comment.
hmm, interesting to see that the Makefile already seemed to have the GO_LDFLAGS referencing this variable, weird to see that this accompanying file wasn't present too. Maybe the file doesn't actually need to exist, but it's helpful to have in the source tree with this comment explaining how it works?
| // SPDX-FileCopyrightText: 2024 The Crossplane Authors <https://crossplane.io> |
There was a problem hiding this comment.
did you already see where/how these headers may be used for build tool automation? i haven't seen that myself yet 🤔 i.e., is there more that would be needed besides this header update?
There was a problem hiding this comment.
I think I update this part according to the feedback from a PR in provider-upjet-template. It seems related to code generator but not sure about it. 😶🌫️ Maybe we don't need this?
My general approach for these updates are based on recent changes from After I finish the change, I will try to build and run in a local environment to test the template-provider is working or not. |
Signed-off-by: Chuan-Yen Chiang <[email protected]>
Description of your changes
This PR is related to crossplane/crossplane#5924, and solve part of it.
I have:
make reviewableto ensure this PR is ready for review.Addedbackport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested