This repository has been archived by the owner on Apr 3, 2020. It is now read-only.
Add gyp flag disable_logging to conditionally disable LOG()/VLOG()/CHECK() for Release build #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DRM devices such as VGEM do not have resources, so we want to ignore them rather than crash. BUG=460982 Review URL: https://codereview.chromium.org/947293002 Cr-Commit-Position: refs/heads/master@{#317687} (cherry picked from commit 3b2bde2) Review URL: https://codereview.chromium.org/956563004 Cr-Commit-Position: refs/branch-heads/2311@{crosswalk-project#14} Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}
Cr-Commit-Position: refs/branch-heads/2311@{crosswalk-project#15}
Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}
Show menu item to view original image if the request could go over the data reduction proxy. BUG=456247 Review URL: https://codereview.chromium.org/944533002 Cr-Commit-Position: refs/heads/master@{#317720} (cherry picked from commit f28021f) Review URL: https://codereview.chromium.org/953053003 Cr-Commit-Position: refs/branch-heads/2311@{crosswalk-project#16} Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}
[email protected] TBR=tnagel NOTREECHECKS=true BUG=451073 Review URL: https://codereview.chromium.org/949173004 Cr-Commit-Position: refs/branch-heads/2311@{crosswalk-project#17} Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}
…ents with a delay, as for ExtensionHosts. extensions::ProcessManager starts ExtensionHosts asynchronously with a queue to avoid using too much resources at startup; make BackgroundContentsService use the same queue implementation. (ExtensionHostQueue now accepts an interface that both BackgroundContentsService and ExtensionHost share.) This significantly reduces the time BackgroundContentsService contributes to ExtensionService startup (75th percentile was ~300ms, according to Extensions.BackgroundContentsServiceStartupTime). BUG=47236 Review URL: https://codereview.chromium.org/933423003 Cr-Commit-Position: refs/heads/master@{#317480} (cherry picked from commit d61dfe1) Review URL: https://codereview.chromium.org/955713004 Cr-Commit-Position: refs/branch-heads/2311@{crosswalk-project#18} Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}
The performance is horrendous, so let's disable the animations for each of the menu items for now as it looks 90% as good as a well performing animation on newer builds of android. BUG=428477 Review URL: https://codereview.chromium.org/948183003 Cr-Commit-Position: refs/heads/master@{#317692} Review URL: https://codereview.chromium.org/927103003 Cr-Commit-Position: refs/branch-heads/2311@{crosswalk-project#19} Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}
Will merge this to M42, then revert on trunk. BUG=460900 Review URL: https://codereview.chromium.org/949753006 Cr-Commit-Position: refs/heads/master@{#317638} (cherry picked from commit 0d59aea) Review URL: https://codereview.chromium.org/948343005 Cr-Commit-Position: refs/branch-heads/2311@{crosswalk-project#20} Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}
Simply hide the Autofill/Wallet preferences. The correct fix will involve checking the state of the sync experiment, but for M42 it's enough to just disable this preference page. Will require merge to m42. BUG=460900 [email protected] Review URL: https://codereview.chromium.org/947253002 Cr-Commit-Position: refs/heads/master@{#317699} (cherry picked from commit 652772c) Review URL: https://codereview.chromium.org/947333003 Cr-Commit-Position: refs/branch-heads/2311@{crosswalk-project#21} Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}
BUG=430328 Review URL: https://codereview.chromium.org/943103002 Cr-Commit-Position: refs/heads/master@{#317489} (cherry picked from commit 01f8886) Review URL: https://codereview.chromium.org/955843002 Cr-Commit-Position: refs/branch-heads/2311@{crosswalk-project#22} Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}
Enables PushManager.hasPermission() as a transition until the Permissions API can be used in order to get that information. It will save a lot of trouble in changing the current test in order to no longer use hasPermission() then change them again to use the Permissions API. This is a three sided CL: 1- https://codereview.chromium.org/926793004 2- <this> 3- https://codereview.chromium.org/936873002 BUG=449178 [email protected],[email protected] Review URL: https://codereview.chromium.org/937563004 Cr-Commit-Position: refs/heads/master@{#317512} (cherry picked from commit 6aa6126) Review URL: https://codereview.chromium.org/950723003 Cr-Commit-Position: refs/branch-heads/2311@{crosswalk-project#23} Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}
Return the y coordinate of the PopupTouchHandleDrawable position when it is requested. Turns out, returning the x coordinate is bad. BUG=461598 Review URL: https://codereview.chromium.org/931283008 Cr-Commit-Position: refs/heads/master@{#317936} (cherry picked from commit 048b41f) Review URL: https://codereview.chromium.org/952263002 Cr-Commit-Position: refs/branch-heads/2311@{crosswalk-project#24} Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}
…wn (patchset crosswalk-project#9 id:350001 of https://codereview.chromium.org/900063002/) Reason for revert: Causes regression in cold start on Android and maybe Mac. Details in http://crbug.com/457248. Original issue's description: > Fixes for two different HUD issues related to win32k lockdown > > 1. Using a GDI bitmap -- switch to SkSurface instead > > 2. Lazily loading a font. This breaks for two different reasons. > The first is a DCHECK for doing IO on the Compositor thread. This > could have been just ignored in general since it's only for debug > usage, the drawbacks of minor jank are limited. > > However, once lockdown is on, the font load hard fails from the > renderer. So, load the typeface before lockdown and pass it into > CC and the hud via LayerTreeSettings. > > [email protected] > BUG=453731,455104 > TEST=run chrome with --enable-win32k-renderer-lockdown --show-fps-counter --ui-show-fps-counter on Win8 > > Committed: https://crrev.com/616a8e656b2d923ed393bde86adc150e555ba799 > Cr-Commit-Position: refs/heads/master@{#314929} [email protected],[email protected],[email protected] BUG=453731,455104,457248 Review URL: https://codereview.chromium.org/922293006 Cr-Commit-Position: refs/heads/master@{#317648} (cherry picked from commit 1793e04) Review URL: https://codereview.chromium.org/951423003 Cr-Commit-Position: refs/branch-heads/2311@{crosswalk-project#25} Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}
The new icons are slightly larger than the previous version, per the feedback we received from various reviews. [email protected], [email protected] BUG=460042 Review URL: https://codereview.chromium.org/946673002 Cr-Commit-Position: refs/heads/master@{#317576} (cherry picked from commit e7a4e69) Review URL: https://codereview.chromium.org/950903005 Cr-Commit-Position: refs/branch-heads/2311@{crosswalk-project#26} Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}
…nabled Previously streams would be intercepted even if the MimeHandlerView plugin associated with them was disabled which would prevent the resource from being download if a plugin wasn't being enabled to handle it. BUG=459383 Review URL: https://codereview.chromium.org/933093002 Cr-Commit-Position: refs/heads/master@{#317673} (cherry picked from commit 553cec8) Review URL: https://codereview.chromium.org/957703005 Cr-Commit-Position: refs/branch-heads/2311@{crosswalk-project#27} Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}
Cr-Commit-Position: refs/branch-heads/2311@{crosswalk-project#28}
Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}
Non-existent dictionary members were trying to be accessed. BUG=461587 Review URL: https://codereview.chromium.org/959443003 Cr-Commit-Position: refs/heads/master@{#317935} (cherry picked from commit 7593306) Review URL: https://codereview.chromium.org/958763002 Cr-Commit-Position: refs/branch-heads/2311@{crosswalk-project#29} Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}
For plugins listed in chrome/browser/resources/plugin_metadata/plugins_*.json, the resource identifier for that plugin becomes the key used in those JSON files. Previously, the PDF plugin filename was used as the resource identifier to whitelist the PDF plugin within the PDF extension. This caused the whitelisting to be ineffective for official builds and also other builds after r316957 added an entry for the Chromium PDF Viewer plugin. This CL fixes this by using the keys from the plugin metadata files as the resource identifiers for whitelisting the PDF plugin. BUG=459998 Review URL: https://codereview.chromium.org/946293002 Cr-Commit-Position: refs/heads/master@{#317556} (cherry picked from commit 2c8ef92) [email protected] Review URL: https://codereview.chromium.org/956163002 Cr-Commit-Position: refs/branch-heads/2311@{crosswalk-project#30} Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}
> BUG=461408 > > Review URL: https://codereview.chromium.org/952833005 > > Cr-Commit-Position: refs/heads/master@{#317882} > (cherry picked from commit a1f4fa3) [email protected] Review URL: https://codereview.chromium.org/960093002 Cr-Commit-Position: refs/branch-heads/2311@{crosswalk-project#31} Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}
…fetched. Before, we were not notifying Files app about such fact, so it was still thinking that Drive is not available, and showing the banner. [email protected] # For merge. TEST=Tested manually when logging to an empty profile. BUG=461247 Review URL: https://codereview.chromium.org/953273002 Cr-Commit-Position: refs/heads/master@{#317995} (cherry picked from commit eaffcdb) Review URL: https://codereview.chromium.org/961593002 Cr-Commit-Position: refs/branch-heads/2311@{crosswalk-project#32} Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}
BUG=446263,457482 Review URL: https://codereview.chromium.org/945063002 Cr-Commit-Position: refs/heads/master@{#317483} (cherry picked from commit cd52b1d) Review URL: https://codereview.chromium.org/960793002 Cr-Commit-Position: refs/branch-heads/2311@{crosswalk-project#33} Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}
This CL fixes focus regression introduced in https://codereview.chromium.org/908033005 BUG=450465 TEST=manual Review URL: https://codereview.chromium.org/951783003 Cr-Commit-Position: refs/heads/master@{#317777} (cherry picked from commit 2672bd9) Review URL: https://codereview.chromium.org/962523004 Cr-Commit-Position: refs/branch-heads/2311@{crosswalk-project#34} Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}
…supervised node. The title can actually change when switching to a different translation, which would trigger a NOTREACHED in BookmarkModel::SetTitle. BUG=459448 Review URL: https://codereview.chromium.org/946363002 Cr-Commit-Position: refs/heads/master@{#317587} (cherry picked from commit 2d81cac) TBR=amineer Review URL: https://codereview.chromium.org/961613002 Cr-Commit-Position: refs/branch-heads/2311@{crosswalk-project#35} Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}
F13 - F15 in particular are needed for lock, key help, and diamond keys on extended ChromeOS keyboards. BUG=454865 Review URL: https://codereview.chromium.org/934003002 Cr-Commit-Position: refs/heads/master@{#317902} (cherry picked from commit 5ee26af) TBR=Wez,spang Review URL: https://codereview.chromium.org/961843002 Cr-Commit-Position: refs/branch-heads/2311@{crosswalk-project#36} Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}
This closes two large holes in the settings code:
(1) Any changes made before the input device thread starts are lost.
(2) Settings are not internally applied to new devices on hotplug.
In theory these problems should not have mattered because there is a
DeviceChangeHandler class to watch for new devices & reapply settings
whenever a new device appears. However, in practice that class is not
actually instantiated. We've had several reports of settings not being
properly applied.
To fix (1) build up desired settings state on the UI thread in
InputControllerEvdev, and push it to InputDeviceFactoryEvdev once the
thread starts.
To fix (2) keep the desired settings state on InputDeviceFactoryEvdev,
and reapply settings on hotplug.
BUG=451743
TEST=Turned on australian scrolling & ran "sudo restart udev" on
link_freon. Verified scrolling is still australian.
Review URL: https://codereview.chromium.org/951063004
Cr-Commit-Position: refs/heads/master@{#317851}
(cherry picked from commit 8ec6aaa)
Review URL: https://codereview.chromium.org/956793002
Cr-Commit-Position: refs/branch-heads/2311@{crosswalk-project#37}
Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}
- Fix the task queue so that cancelling a task doesn't leave it hanging out in the queue, which then will jam everything up. - Fix the error code so that errors are handled consistently (and are non-terminal, as they should be) - Rename UpdateType.SUCCESS to UpdateType.COMPLETE. This better reflects the fact that errors can occur during an import task but the task still runs to completion. BUG=460597 Review URL: https://codereview.chromium.org/947583002 Cr-Commit-Position: refs/heads/master@{#317538} (cherry picked from commit fb5551a) TBR=mtomasz Review URL: https://codereview.chromium.org/964533003 Cr-Commit-Position: refs/branch-heads/2311@{crosswalk-project#38} Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}
Cr-Commit-Position: refs/branch-heads/2311@{crosswalk-project#39}
Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}
The old Chromoting code (policy_hack before crrev.com/830193002) used to always read Chromoting policies from the registry. The new code (using components/policy) ignores contents of the registry on non-domain-joined machines. This old-vs-new difference in behavior was unintentional. The current changelist ensures that Chromoting's old behavior is preserved. BUG=460734 TEST=1) components_unittests.exe, 2) remoting_unittests.exe, 3) remoting_unittests.exe --gtest_filter=*PolicyWatcher*Real* -v=1 copied and run from a non-domain-joined, test VM to verify that Chromoting gets its policies from the registry (HKLM\SOFTWARE\Policies\Google\Chrome) in this scenario. Review URL: https://codereview.chromium.org/947353002 Cr-Commit-Position: refs/heads/master@{#317865} (cherry picked from commit bccb49e) TBR=dcaiafa Review URL: https://codereview.chromium.org/959033002 Cr-Commit-Position: refs/branch-heads/2311@{crosswalk-project#40} Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}
Cleanup log record formatting (added missing spaces, remove redundant info). Move machine id to from of log file names so they read better (really). BUG=460614 TEST=None // Well, you can start import, then yank the card to see if you can't force an error to happen, then check the network tab to see that a GA "exception" was sent with JUST the static error-context string from the related promise. Review URL: https://codereview.chromium.org/953483003 Cr-Commit-Position: refs/heads/master@{#317833} (cherry picked from commit 15a10b6) Add support for log file rotation. Clean up error logging (more consistent formatting). Log stack traces. Ensure most substantial Promise chains used in importer code have catch clause hooked up to logger. BUG=460614 BUG=449034 TEST=browser_test: FileManagerJsTest.* Review URL: https://codereview.chromium.org/945933003 Cr-Commit-Position: refs/heads/master@{#317547} (cherry picked from commit 4b600b5) TBR=mtomasz Review URL: https://codereview.chromium.org/964643002 Cr-Commit-Position: refs/branch-heads/2311@{crosswalk-project#41} Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}
1) Use seconds-since-epoch in log record keys, instead of full date strings. 2) Add support for inflating/deflating urls. 3) Deflate URLS prior to storaing in log file. 4) Remove obsolete code for reloading history after remote changes. BUG=461176 TEST=browser_test: FileManagerJsTest.* Review URL: https://codereview.chromium.org/954583004 Cr-Commit-Position: refs/heads/master@{#317965} (cherry picked from commit 1f0ca0d) TBR=mtomasz Review URL: https://codereview.chromium.org/963593004 Cr-Commit-Position: refs/branch-heads/2311@{crosswalk-project#42} Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}
[email protected], [email protected] BUG=459778 TEST=chromote locally with enableVideoDecodeRenderer Review URL: https://codereview.chromium.org/954073002 Cr-Commit-Position: refs/heads/master@{#317985} NOTRY=true Review URL: https://codereview.chromium.org/957403004 Cr-Commit-Position: refs/branch-heads/2311@{crosswalk-project#43} Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}
rakuco
force-pushed
the
master
branch
2 times, most recently
from
5d9bef8 to
18a33ff
Compare
mrunalk
pushed a commit
that referenced
this pull request
Sep 22, 2015
It appears to do both a read and a write on KK. Whitelist the write. BUG=527415 TBR=agrieve Review URL: https://codereview.chromium.org/1345443002 Cr-Commit-Position: refs/heads/master@{#348614} (cherry picked from commit b1068c5) Review URL: https://codereview.chromium.org/1337993003 . Cr-Commit-Position: refs/branch-heads/2490@{#242} Cr-Branched-From: 7790a35-refs/heads/master@{#344925}
rakuco
force-pushed
the
master
branch
2 times, most recently
from
830d9f6 to
5ad5a18
Compare
mrunalk
pushed a commit
that referenced
this pull request
Dec 18, 2015
Now that there can be multiple Overlays Panels being used, a few bugs are happening due to the Panel's cc::Layer not being properly removed. This CL fixes the problem by removing the layer when a OverlayPanel shows up when another one is being displayed. Also, this CL removed the OverlayPanel layer from the StaticLayout whenever that layout gets hidden (see dettachViews method). BUG=539847 Review URL: https://codereview.chromium.org/1489213002 Cr-Commit-Position: refs/heads/master@{#363092} (cherry picked from commit a53e46e) Review URL: https://codereview.chromium.org/1502703002 . Cr-Commit-Position: refs/branch-heads/2564@{#242} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
rakuco
force-pushed
the
master
branch
2 times, most recently
from
1072537 to
512d729
Compare
rakuco
force-pushed
the
master
branch
2 times, most recently
from
0f31e18 to
3da217c
Compare
rakuco
pushed a commit
that referenced
this pull request
Mar 3, 2016
Hash changes don't trigger |-didFinishNavigation|, so favicons must be fetched manually. BUG=531267 Review URL: https://codereview.chromium.org/1360543004 Cr-Commit-Position: refs/heads/master@{#372731} (cherry picked from commit 61b25a2) Review URL: https://codereview.chromium.org/1663463002 . Cr-Commit-Position: refs/branch-heads/2623@{#242} Cr-Branched-From: 92d7753-refs/heads/master@{#369907}
huningxin
pushed a commit
to huningxin/chromium-croswalk
that referenced
this pull request
May 17, 2016
BUG=594381 Review URL: https://codereview.chromium.org/1803823002 Cr-Commit-Position: refs/heads/master@{#381078} (cherry picked from commit e086724) Review URL: https://codereview.chromium.org/1805093002 . Cr-Commit-Position: refs/branch-heads/2661@{crosswalk-project#242} Cr-Branched-From: ef6f6ae-refs/heads/master@{#378081}
huningxin
pushed a commit
to huningxin/chromium-croswalk
that referenced
this pull request
Oct 9, 2016
Send synthetic middle click in history page and also prevent default it as the links in history page will trigger twice if we don't prevent default it. BUG=609020 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2018943003 Cr-Commit-Position: refs/heads/master@{#397512} (cherry picked from commit a154aed) Review URL: https://codereview.chromium.org/2040813003 . Cr-Commit-Position: refs/branch-heads/2743@{crosswalk-project#242} Cr-Branched-From: 2b3ae3b-refs/heads/master@{#394939}
imreotto
pushed a commit
to tenta-browser/chromium-crosswalk
that referenced
this pull request
Nov 2, 2017
[email protected] Change-Id: I58e2e3f68b7068610057067fe3e9c9d61a82c37d Reviewed-on: https://chromium-review.googlesource.com/667322 Reviewed-by: [email protected] <[email protected]> Cr-Commit-Position: refs/branch-heads/3202@{crosswalk-project#242} Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUG=https://crosswalk-project.org/jira/browse/XWALK-3792
TEST=Build with/without disable_logging=1
build/android/test_runner.py instrumentation --test-apk=XWalkCoreTest --release
SIZE_REDUCED=140k