This repository has been archived by the owner on Apr 3, 2020. It is now read-only.
[Android] Enable copy picture only in contenteditable #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Testing patch series with axinging/chromium-crosswalk@9fe7931bb1f9cd689485dfc34ec098f120e9fb9f as its head.
|
|
@halton @lincsoon @kenchris @darktears |
|
Thanks @halton |
|
@axinging this PR is broken, please rebase. |
|
Testing patch series with axinging/chromium-crosswalk@c33ece86d3b111af3b4ddb3f4de5f74737af7b5a as its head.
|
|
Testing patch series with axinging/chromium-crosswalk@17333d20ef1e18acdb507c11c87118d81a5512a9 as its head.
|
|
OK, now let's go go go! @halton @lincsoon @kenchris @darktears |
| // available, because otherwise others apps may not be able to paste it. | ||
| if (!ContainsKey(map_, kPlainTextFormat)) | ||
| return; | ||
|
|
There was a problem hiding this comment.
Neither disable or enable HTML P&P unconditionally does not make any sense . Can we expose this key via XWalkPreferences, so that developer can control it via this key.
There was a problem hiding this comment.
Please refer to :https://code.google.com/p/chromium/issues/detail?id=469565
Currently, copy/paste picture only is intentionally disabled. Because of copy/paste picture only isn't being good supported in Android system. The detail behavior of current chrome for android are listed below:
1),Copy picture(s) with text from chrome for Android and pastes it into an Android
apps, it seldom works,picture(s) turns into "OBJ".
2),Copy picture(s) only from chrome for Android and pastes it into an Android apps, it seldom works,picture(s) turns into "OBJ".
3),Copy/paste picture(s) with text in chrome for Android, it works.
4),Copy/paste picture(s) only in chrome for Android, it doesn't work.
It's poor user experience for item 3) and item 4).
So this fix is intent to align item 3) and 4).
|
The chromium related commit: https://codereview.chromium.org/25668005 |
rakuco
pushed a commit
that referenced
this pull request
Apr 30, 2015
…tions. (patchset #1 id:1 of https://codereview.chromium.org/1107383002/) Reason for revert: Merge issue broke cros build https://uberchromegw.corp.google.com/i/chrome/builders/cros%20beta/builds/8333 Original issue's description: > Merge Prevent DisplayPreferences from saving incorrect rotations. > Refactor DisplayInfo::rotation_ to track different sources of rotations > > Currently DisplayInfo only tracks the active rotation for the given display. > DisplayPreferences however saves a user rotation, as well as an accelerometer > rotation. DisplayController::Observer::OnDisplayConfigurationChanged triggers > the saving of display preferences. > > This has been leading to active accelerometer rotations being saved as user > preferences, and being re-applied upon reboot. > > This change refactors DisplayInfo to track one rotation per source of rotation > changes. DisplayPreferences has been updated to save based on these states. > > TEST=DisplayPreferencesTest.DontSaveMaximizeModeControllerRotations, also ran > ash_unittests, and unit_tests > BUG=chrome-os-partner:37555, 469752, 466861 > [email protected], [email protected], [email protected] > NOTRY=true > NOPRESUBMIT=true > > Review URL: https://codereview.chromium.org/1071353003 > > Cr-Commit-Position: refs/heads/master@{#326614} > (cherry picked from commit d01de7f) [email protected],[email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chrome-os-partner:37555, 469752, 466861 Review URL: https://codereview.chromium.org/1108343002 Cr-Commit-Position: refs/branch-heads/2357@{#249} Cr-Branched-From: 59d4494-refs/heads/master@{#323860}
|
@halton, please help to review. |
|
@axinging thanks for update, please rebase your code. |
|
Testing patch series with axinging/chromium-crosswalk@bc00184858990af5e615d955269d8052bf5d19ba as its head.
|
The compile-time flag "enable_hotwording" is now tied to branding=Chrome (false by default unless making a Google Chrome build). Note: Chromium will no longer download/install the Hotword Shared Module, and will automatically remove the Hotword Shared Module on startup if it was previously installed. To keep this functionality, add "enable_hotwording=1" to GYP_DEFINES. BUG=500922 Review URL: https://codereview.chromium.org/1200413003 Cr-Commit-Position: refs/heads/master@{#335874} (cherry picked from commit 0366a51) Fix up HotwordServiceTest on Chrome-branded builds. The ENABLE_HOTWORDING flag is not available in hotword_service_unittest.cc, so all tests were assuming hotwording was disabled (since r333548). This has been failing on Official builders since r335874. Since it's hard to resolve this in a simple way (we want to merge these changes), just disabling the tests is the cleanest option for now. BUG=503963 Review URL: https://codereview.chromium.org/1207163002 Cr-Commit-Position: refs/heads/master@{#336091} (cherry picked from commit 8ef0bc3) Resolved merge conflict: Disabled IsHotwordAllowedDisabledFieldTrial and IsHotwordAllowedInvalidFieldTrial. These tests were deleted before the upstream patch landed. (Merge approval on http://crbug.com/500922#c69) [email protected] [email protected] Review URL: https://codereview.chromium.org/1211273003. Cr-Commit-Position: refs/branch-heads/2403@{#416} Cr-Branched-From: f54b809-refs/heads/master@{#330231}
…lt." This reverts commit 86fb78f. Commit broke the build due to merge failure. BUG=505351 [email protected] Review URL: https://codereview.chromium.org/1218763002. Cr-Commit-Position: refs/branch-heads/2403@{#417} Cr-Branched-From: f54b809-refs/heads/master@{#330231}
The compile-time flag "enable_hotwording" is now tied to branding=Chrome (false by default unless making a Google Chrome build). Note: Chromium will no longer download/install the Hotword Shared Module, and will automatically remove the Hotword Shared Module on startup if it was previously installed. To keep this functionality, add "enable_hotwording=1" to GYP_DEFINES. BUG=500922 Review URL: https://codereview.chromium.org/1200413003 Cr-Commit-Position: refs/heads/master@{#335874} (cherry picked from commit 0366a51) Fix up HotwordServiceTest on Chrome-branded builds. The ENABLE_HOTWORDING flag is not available in hotword_service_unittest.cc, so all tests were assuming hotwording was disabled (since r333548). This has been failing on Official builders since r335874. Since it's hard to resolve this in a simple way (we want to merge these changes), just disabling the tests is the cleanest option for now. BUG=503963 Review URL: https://codereview.chromium.org/1207163002 Cr-Commit-Position: refs/heads/master@{#336091} (cherry picked from commit 8ef0bc3) Resolved merge conflict: Disabled IsHotwordAllowedDisabledFieldTrial and IsHotwordAllowedInvalidFieldTrial. These tests were deleted before the upstream patch landed. (Merge approval on http://crbug.com/500922#c69) [email protected] [email protected] Committed: https://chromium.googlesource.com/chromium/src/+/86fb78f02492b2990307ed427c09670f2fff0d3b Review URL: https://codereview.chromium.org/1211273003. Cr-Commit-Position: refs/branch-heads/2403@{#418} Cr-Branched-From: f54b809-refs/heads/master@{#330231}
When detach a layer from old LayerTreeHost and attach it to new one, both old and new LayerTreeHost need to rebuild their property trees. Layer now has stale indices for property trees, invalidate them. Old LayerTreeHost also needs to be rebuilt because detaching a layer might change the property trees' structures. This change needs to go into M44. BUG=497952,504959 TBR=enne, vollick CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1166233002 Cr-Commit-Position: refs/heads/master@{#333417} (cherry picked from commit c4d2e74) Review URL: https://codereview.chromium.org/1217883002. Cr-Commit-Position: refs/branch-heads/2403@{#419} Cr-Branched-From: f54b809-refs/heads/master@{#330231}
This addresses the most egregious problems so that we look more or less like a reasonable app on Win10. In particular, fixes a too-wide border, removing the rounded corners on the toolbar that don't work when there's no border (see 504044 for agreement from UX), and an ugly overhang in the non-client area in the top-left and top-right of the window. In case you're not familiar with Win10 UI style (I wasn't!) I put a composite of what standard apps plus before/after this patch here http://i.imgur.com/JxNJvBv.png . We aren't easily able to switch to a more "grey"-style title bar at the moment as that's reserved for Windows-store applications (plain Win32 apps like notepad and chrome always get the white title bar style). We might want to look into that in the future as it's pretty harsh, but at least we match the expected system behaviour this way. [email protected] BUG=504044,502001 Review URL: https://codereview.chromium.org/1209723004 Cr-Commit-Position: refs/heads/master@{#336438} (cherry picked from commit 48ddea0) Review URL: https://codereview.chromium.org/1213243002. Cr-Commit-Position: refs/branch-heads/2403@{#420} Cr-Branched-From: f54b809-refs/heads/master@{#330231}
This is implemented in AppCompat now and our custom implementation was causing bugs (e.g. the cursor was showing up white). BUG=497608 [email protected] Review URL: https://codereview.chromium.org/1169903003 Cr-Commit-Position: refs/heads/master@{#333762} Review URL: https://codereview.chromium.org/1210153005. Cr-Commit-Position: refs/branch-heads/2403@{#421} Cr-Branched-From: f54b809-refs/heads/master@{#330231}
…etricsPrivate API. Add extension IDs for all versions of remoting apps to permissions list of metricsPrivate API. BUG=500086 TBR=jamiewalch NOTRY=true NOPRESUBMIT=true Review URL: https://codereview.chromium.org/1184353005 Cr-Commit-Position: refs/heads/master@{#334687} (cherry picked from commit e46057f) Add Chrome Remote Desktop to approved extensions list of metrics-private API. BUG=500086 Review URL: https://codereview.chromium.org/1186983002 Cr-Commit-Position: refs/heads/master@{#334486} (cherry picked from commit c1dfbaf) Review URL: https://codereview.chromium.org/1215733003 Cr-Commit-Position: refs/branch-heads/2403@{#422} Cr-Branched-From: f54b809-refs/heads/master@{#330231}
BUG=504014 TEST=manually Review URL: https://codereview.chromium.org/1207893004 Cr-Commit-Position: refs/heads/master@{#336314} (cherry picked from commit 221df22) Review URL: https://codereview.chromium.org/1217753004. Cr-Commit-Position: refs/branch-heads/2403@{#423} Cr-Branched-From: f54b809-refs/heads/master@{#330231}
Cr-Commit-Position: refs/branch-heads/2403@{#424}
Cr-Branched-From: f54b809-refs/heads/master@{#330231}
Before this CL, any proxy that was previously marked as bad could not be assigned a different retry delay, and could only be marked as bad for the previous retry delay. This CL changes the proxy retry map update logic to replace the existing bad proxy retry info if the new retry time is later than the existing retry time. BUG=500738 Review URL: https://codereview.chromium.org/1191823002 Cr-Commit-Position: refs/heads/master@{#336451} (cherry picked from commit 08141d9) Review URL: https://codereview.chromium.org/1212643009. Cr-Commit-Position: refs/branch-heads/2403@{#425} Cr-Branched-From: f54b809-refs/heads/master@{#330231}
|
Agree with @rakuco that this needs to be submitted upstream. There has been plenty of time to do it. |
|
I'd also like to add that our rebases are taking longer and longer for each release, therefore we need to be extremely careful about what extra patches we take in. |
rakuco
force-pushed
the
master
branch
2 times, most recently
from
5d9bef8 to
18a33ff
Compare
rakuco
force-pushed
the
master
branch
2 times, most recently
from
830d9f6 to
5ad5a18
Compare
mrunalk
pushed a commit
that referenced
this pull request
Dec 18, 2015
Breaks caret rendering at rightmost edge of some situations. This reverts commit 5fdc15a. BUG=548596,523969 TBR=chrishtr Review URL: https://codereview.chromium.org/1451103005 Cr-Commit-Position: refs/heads/master@{#360247} (cherry picked from commit 4a57b23) Review URL: https://codereview.chromium.org/1508593002 . Cr-Commit-Position: refs/branch-heads/2564@{#249} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
rakuco
force-pushed
the
master
branch
2 times, most recently
from
1072537 to
512d729
Compare
rakuco
force-pushed
the
master
branch
2 times, most recently
from
0f31e18 to
3da217c
Compare
rakuco
pushed a commit
that referenced
this pull request
Mar 3, 2016
Remove use of linked_ptr, because it's not necessary now that we have C++11 support. Separate out functions to be a bit easier to read and follow. Remove unnecessary uses of RectF when Rect would do. BUG=533681 Review URL: https://codereview.chromium.org/1643043002 Cr-Commit-Position: refs/heads/master@{#372707} (cherry picked from commit 4d0aa96) Mac overlays: Move CALayerPartialDamageTree to its own file Direct copy-paste, no changes. BUG=533681 TBR=erikchen Review URL: https://codereview.chromium.org/1647523002 Cr-Commit-Position: refs/heads/master@{#371871} (cherry picked from commit 9a9014a) Mac overlays: Isolate partial swap support The logic to maintain a CALayer tree for partial swap support is complicated and should be removed, but that would compromise battery usage. Once the CoreAniamtion renderer is handling ~99% of the frames, we can remove it. In the mean time, isolate it. Create a CALayerPartialDamageTree to track the layer tree of partially swapped backbuffers. Do this in-place to minimize diffs, so that this patch can be reasonably reviewed. A follow-on patch will move it to a separate file. Slightly reorganize the logic so that CALayerPartialDamageTree matches the general structure of CALayerTree, where this a pending (not swapped) tree, a tree for each pending swap, and a tree for what is currently being displayed. BUG=533681 Review URL: https://codereview.chromium.org/1640093002 Cr-Commit-Position: refs/heads/master@{#371831} (cherry picked from commit 8aa00fc) Review URL: https://codereview.chromium.org/1661453003 . Cr-Commit-Position: refs/branch-heads/2623@{#249} Cr-Branched-From: 92d7753-refs/heads/master@{#369907}
huningxin
pushed a commit
to huningxin/chromium-croswalk
that referenced
this pull request
May 17, 2016
This will force old configs to add this setting on the next update, and thus get rid of the "missing i386" warning for existing users. [email protected], [email protected] BUG=591480 Review URL: https://codereview.chromium.org/1801283002 Cr-Commit-Position: refs/heads/master@{#381287} (cherry picked from commit 8b58c0d) Review URL: https://codereview.chromium.org/1804263002 . Cr-Commit-Position: refs/branch-heads/2661@{crosswalk-project#249} Cr-Branched-From: ef6f6ae-refs/heads/master@{#378081}
huningxin
pushed a commit
to huningxin/chromium-croswalk
that referenced
this pull request
Oct 9, 2016
Extensions have HW H264 encode enabled in 51. However SW implementations of H264 isn't enabled by default. So, we need to be careful about SW fallback as we cannot do it when it isn't available. BUG=615513 Review-Url: https://codereview.chromium.org/2024303003 Cr-Commit-Position: refs/heads/master@{#397856} (cherry picked from commit 177cc1d) NOTRY=true NOPRESUBMIT=true [email protected] Review-Url: https://codereview.chromium.org/2044643002 Cr-Commit-Position: refs/branch-heads/2743@{crosswalk-project#249} Cr-Branched-From: 2b3ae3b-refs/heads/master@{#394939}
imreotto
pushed a commit
to tenta-browser/chromium-crosswalk
that referenced
this pull request
Nov 2, 2017
If the application is shutting down, the task may run on a shutdowned service. Make the call static (so it does not need the service) and mark it SKIP_ON_SHUTDOWN. Also mark it USER_VISIBLE as it delays the offline feature of ReadingList. [email protected] (cherry picked from commit a859436) Bug: 762577 Change-Id: I05acf8e58b4dcdf9d21d5ee7e3f352d48f76f699 Reviewed-on: https://chromium-review.googlesource.com/654860 Commit-Queue: Olivier Robin <[email protected]> Reviewed-by: Sylvain Defresne <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#500592} Reviewed-on: https://chromium-review.googlesource.com/668539 Reviewed-by: Olivier Robin <[email protected]> Cr-Commit-Position: refs/branch-heads/3202@{crosswalk-project#249} Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Android, copy/paste picture only isn't being good supported.
In chromium for Android, it supports copy/paste text with picture.
In order to align with Android, chromium for Android disabled
copy/paste picture only previously.
But copy/paste picture only and text with picture among chromium
for Android and Android native applications behave the same.
So we enable copy/paste picture only.
BUG=XWALK-3764
(cherry picked from commit 5dc950d)