This repository has been archived by the owner on Apr 3, 2020. It is now read-only.
fix package name validation #162
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
you can see accepted aplications in google play that contain number in the first part of package name, those apps cant be build with crosswalk and intel xdk because of this validation bug\unconsist with google play. for example this package: http://bit.ly/1aVO6Re
|
we should use theire working regex I think: |
|
anyone? cant understand why not fixing this simple bug? |
|
ping @fujunwei @huningxin |
|
Thanks so much. I think it's perfect solution if you cherry pick this commit to the branch apache/cordova-android@e4c9beb. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
you can see accepted aplications in google play that contain number in the first part of package name, those apps cant be build with crosswalk and intel xdk because of this validation bug\inconsistent with google play. for example this package: http://bit.ly/1aVO6Re