Skip to content
This repository has been archived by the owner on Apr 3, 2020. It is now read-only.

Add binary data transfer from .net extensions, as per XWALK-4615. #3963

Merged
merged 1 commit into from
Dec 13, 2016
Merged

Add binary data transfer from .net extensions, as per XWALK-4615. #3963

merged 1 commit into from
Dec 13, 2016

Conversation

zcr01
Copy link
Contributor

@zcr01 zcr01 commented Dec 12, 2016

No description provided.

@crosswalk-trybot
Copy link

crosswalk-trybot commented Dec 12, 2016 •
edited
Loading

Testing patch series with zcr01/crosswalk@2967c50 as its head.

Bot Status
Crosswalk Android-X86 [SUCCESS 💚](https://build.crosswalk-project.org/try/builders/Crosswalk Android-X86/builds/4882)
Crosswalk Android x86-64 [SUCCESS 💚](https://build.crosswalk-project.org/try/builders/Crosswalk Android x86-64/builds/1932)
Crosswalk Linux [SUCCESS 💚](https://build.crosswalk-project.org/try/builders/Crosswalk Linux/builds/4872)

@zcr01 zcr01 mentioned this pull request Dec 12, 2016
Open
@darktears
Copy link
Contributor

Thanks for the patch. You should probably rebase your patch to the current master (I can see a Merge branch 'master' of https://github.com/zcr01/crosswalk into HEAD")

Also it's missing tests.

@zcr01
Copy link
Contributor Author

zcr01 commented Dec 13, 2016

Tests are here: crosswalk-project/crosswalk-test-suite#3847

@crosswalk-trybot
Copy link

crosswalk-trybot commented Dec 13, 2016 •
edited
Loading

Testing patch series with zcr01/crosswalk@f73c03a as its head.

Bot Status
Crosswalk Android-X86 [SUCCESS 💚](https://build.crosswalk-project.org/try/builders/Crosswalk Android-X86/builds/4883)
Crosswalk Android x86-64 [SUCCESS 💚](https://build.crosswalk-project.org/try/builders/Crosswalk Android x86-64/builds/1933)
Crosswalk Linux [SUCCESS 💚](https://build.crosswalk-project.org/try/builders/Crosswalk Linux/builds/4873)

@darktears
Copy link
Contributor

It should be there : https://github.com/crosswalk-project/crosswalk/tree/master/extensions/test/win

@zcr01
Copy link
Contributor Author

zcr01 commented Dec 13, 2016

Ok - I'll put tests over there, probably tomorrow at this point. Sorry, first pr and the contribute page directed me to the other repository.

@crosswalk-trybot
Copy link

crosswalk-trybot commented Dec 13, 2016 •
edited
Loading

Testing patch series with zcr01/crosswalk@1155c39 as its head.

Bot Status
Crosswalk Android-X86 FAILED 💔
Crosswalk Android x86-64 FAILED 💔
Crosswalk Linux FAILED 💔

@crosswalk-trybot
Copy link

crosswalk-trybot commented Dec 13, 2016 •
edited
Loading

Testing patch series with zcr01/crosswalk@f982fef as its head.

Bot Status
Crosswalk Android-X86 SUCCESS 💚
Crosswalk Android x86-64 SUCCESS 💚
Crosswalk Linux SUCCESS 💚

@crosswalk-trybot
Copy link

crosswalk-trybot commented Dec 13, 2016 •
edited
Loading

Testing patch series with zcr01/crosswalk@88b2d88 as its head.

Bot Status
Crosswalk Android-X86 SUCCESS 💚
Crosswalk Android x86-64 SUCCESS 💚
Crosswalk Linux SUCCESS 💚

@crosswalk-trybot
Copy link

crosswalk-trybot commented Dec 13, 2016 •
edited
Loading

Testing patch series with zcr01/crosswalk@9f04529 as its head.

Bot Status
Crosswalk Android-X86 SUCCESS 💚
Crosswalk Android x86-64 SUCCESS 💚
Crosswalk Linux SUCCESS 💚

@zcr01
Copy link
Contributor Author

zcr01 commented Dec 13, 2016

Added tests and cleaned the history.

@darktears
Copy link
Contributor

Could you please just reformat the commit message to :

[Windows] Add binary data transfer for .net extensions
Explain the commit here.

BUG=XWALK-4615

@zcr01
[Windows] Add binary data transfer from .net extensions.
697b2af 
Exposes PostBinaryMessageToJS(byte[] data, ulong size) to the .net extension bridge.
 - Uses XW_MessagingInterface2 to return an ArrayBuffer to the Javascript client
 - Improves data transfer speed for large amounts of raw data, as translating from a string is slow in Javascript.

BUG=XWALK-4615
@crosswalk-trybot
Copy link

crosswalk-trybot commented Dec 13, 2016 •
edited
Loading

Testing patch series with zcr01/crosswalk@697b2af as its head.

Bot Status
Crosswalk Android-X86 SUCCESS 💚
Crosswalk Android x86-64 SUCCESS 💚
Crosswalk Linux SUCCESS 💚

@darktears
Copy link
Contributor

LGTM. I'll merge when the bots are green. Thanks for the patch.

@darktears darktears merged commit 6f1dd50 into crosswalk-project:master Dec 13, 2016
@rakuco
Copy link
Contributor

rakuco commented Dec 19, 2016

@darktears @zcr01: I think this broke our official Windows canary builds:

[11955/17412] ACTION //xwalk/extensions/test/win:dotnet_binary_extension__msbuild(//build/toolchain/win:x64)
FAILED: tests/dotnet_extension/binary_extension/binary_extension.dll 
C:/Users/blduser/workdir/src/depot_tools/python276_bin/python.exe ../../xwalk/tools/msbuild_dotnet.py --build-type Release --environment-file environment.x64 --project ../../xwalk/extensio
ns/test/win/binary_extension/binary_extension.csproj --output-dir tests/dotnet_extension/binary_extension
XWalkExtension.cs(20,7): error CS1039: Unterminated string literal [C:\Users\blduser\workdir\src\src\xwalk\extensions\test\win\binary_extension\binary_extension.csproj]
XWalkExtension.cs(33,1): error CS1002: ; expected [C:\Users\blduser\workdir\src\src\xwalk\extensions\test\win\binary_extension\binary_extension.csproj]
XWalkExtension.cs(33,1): error CS1513: } expected [C:\Users\blduser\workdir\src\src\xwalk\extensions\test\win\binary_extension\binary_extension.csproj]
Traceback (most recent call last):
  File "../../xwalk/tools/msbuild_dotnet.py", line 70, in <module>
    sys.exit(main())
  File "../../xwalk/tools/msbuild_dotnet.py", line 66, in main
    LaunchMSBuild(options)
  File "../../xwalk/tools/msbuild_dotnet.py", line 48, in LaunchMSBuild
    subprocess.check_call(cmd)
  File "C:\Users\blduser\workdir\src\depot_tools\python276_bin\lib\subprocess.py", line 540, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['msbuild', '/nologo', '/p:Platform=AnyCPU,Configuration=Release,OutDir=C:\\Users\\blduser\\workdir\\src\\src\\out\\Release\\tests\\dotnet_extension
\\binary_extension,BaseIntermediateOutputPath=C:\\Users\\blduser\\workdir\\src\\src\\out\\Release\\tests\\dotnet_extension\\binary_extension\\', '/verbosity:quiet', '../../xwalk/extensions
/test/win/binary_extension/binary_extension.csproj']' returned non-zero exit status 1

darktears
darktears reviewed Dec 19, 2016
View reviewed changes
extensions/test/win/binary_extension/XWalkExtension.cs
exports.binaryEcho = function(msg, callback) {
binaryTestListener = callback;
extension.postMessage(msg);
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's missing a " here.

@zcr01
Copy link
Contributor Author

zcr01 commented Dec 19, 2016 •
edited
Loading

Should be fixed now. I think I must have messed something up in the rebase and missed the commit where I fixed that. #3969

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@darktears darktears darktears left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zcr01 @crosswalk-trybot @darktears @rakuco