Add support to the Chef Corosync cookbook for RHEL based distros and make it testable #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for RHEL platform_family - Add the LICENSE file - Add berks and test-kitchen config which are needed for cookbook testing
platform_family. The version is kept at '0' on suse but on RHEL version '1' is used. - Reformat the template content
…ing compilation phase when authey is nil
…n. Minor code formatting.
… required packages
… corosync init script that was being setup for non-suse platforms only needs to be setup for debian based distros
…ore than 1 instances so that they can communicate with each other
| @@ -64,7 +63,7 @@ | |||
| pkg = package rubygem_ruby_shadow do | |||
| action :nothing | |||
| end | |||
| pkg.run_action(:install) if node.platform == "suse" | |||
| pkg.run_action(:install) if node["platform_family"] == 'suse' | |||
There was a problem hiding this comment.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
| template "/etc/sysconfig/SuSEfirewall2.d/services/cluster" do | ||
| source "firewall.erb" | ||
| mode "0640" | ||
| owner "root" | ||
| variables( | ||
| mcast_port: node[:corosync][:mcast_port] | ||
| :mcast_port => node[:corosync][:mcast_port] |
There was a problem hiding this comment.
Style/HashSyntax: Use the new Ruby 1.9 hash syntax.
| @@ -17,11 +18,13 @@ | |||
| # limitations under the License. | |||
| # | |||
|
|
|||
| authkey = node[:corosync][:authkey] | |||
| require 'base64' | |||
There was a problem hiding this comment.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
|
Thanks a lot - will take a look ASAP! |
|
@aspiers is there anything I can do here? |
|
@aspiers this looks like its still blocked for some reason. Anything you want me to do here? |
|
As with #17 (comment) it would be great if you could fix the Hound CI warnings and rebase. Thanks a lot for your patience! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #9