Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plat-14318 remove cli #1122

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Plat-14318 remove cli #1122

wants to merge 6 commits into from

Conversation

taylor-cb
Copy link
Contributor

Ticket

Plat-14318
Related tickets:
Related PRs:

Type of PR

  • Bugfix
  • New feature
  • Minor changes

Did you make changes to modules or created a new module?

Changes introduced

Removing CLI from modules repo, as it's now been moved to https://github.com/crowdbotics/cli

@taylor-cb taylor-cb requested a review from danielsousaio April 10, 2024 18:18
Metalheart88
Metalheart88 previously approved these changes Apr 10, 2024
README.md Outdated
Comment on lines 33 to 35
- [python](https://www.python.org/)
- [pipenv](https://pypi.org/project/pipenv/)
- [urllib3](https://urllib3.readthedocs.io/en/stable/) without this the project will not run in ```macOS``` environments
- [urllib3](https://urllib3.readthedocs.io/en/stable/) without this the project will not run in `macOS` environments
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are cli requirements, we should mention that one must install the cli and its requirements and just link to crowdbotics/cli repo

danielsousaio
danielsousaio previously approved these changes Apr 10, 2024
Copy link
Collaborator

@danielsousaio danielsousaio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a minor thing on the readme

@taylor-cb taylor-cb dismissed stale reviews from danielsousaio and Metalheart88 via 31b87a6 April 10, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants