Add vpatch-CVE-2024-21650 rule and test #1484
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rule targets the XWiki user registration endpoint vulnerable to RCE via the "first name" or "last name" fields. The detection logic is as follows:
/bin/register/xwiki/xwikiregister
), using bothlowercase
andurldecode
transforms to ensure case-insensitive and encoded/decoded matching.register_first_name
andregister_last_name
fields, for the presence of the string{{groovy}}
(case-insensitive, URL-decoded). This string is a strong indicator of an attempt to inject Groovy code, which is the vector for RCE in this vulnerability.register_first_name
containing the Groovy macro, and expects a 403 response to confirm the rule blocks the attack.Validation checklist:
value:
fields are lowercase.lowercase
andurldecode
.match.value
contains capital letters.contains
for matching, notregex
, as per guidelines.