Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format jsonl not working #37

Open
dror-g opened this issue Apr 24, 2024 · 3 comments
Open

Format jsonl not working #37

dror-g opened this issue Apr 24, 2024 · 3 comments

Comments

@dror-g
Copy link

dror-g commented Apr 24, 2024

Hi, tried setting the format to jsonl like so:

format:
  format_type: jsonl
  format_parquet:
    validate: false

Got immediate error:
'jsonl' is not a valid choice for 'format.format_type'

Using Meltano Docker image latest

Thanks for all your hard work!!!

@dror-g
Copy link
Author

dror-g commented Apr 28, 2024

Oh I realise the Meltano hub definitions need updating (weird. why would it break plugins?).
Opened a pull request there to add jsonl option and label.

@crowemi
Copy link
Owner

crowemi commented Apr 29, 2024

Hey @dror-g -- I'm not seeing the PR 🤔

@dror-g
Copy link
Author

dror-g commented Apr 30, 2024

Oh sorry @crowemi , I meant that I opened a PR for Meltano Hub repo to add the Jsonl label & value to hub definitions.

meltano/hub@65aaddb

(This issue can be closed after verifying it works. Thanks again for your work!!!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants