Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preregistration for Quantitative Research in Psychology Template #15

Merged
merged 12 commits into from
Nov 26, 2020

Conversation

LisaSpitzerZPID
Copy link
Contributor

I included the "Preregistration for Quantitative Research in Psychology Template" created by a task force composed of members of the American Psychological Association (APA), the British Psychological Society (BPS), the German Psychological Society (DGPs), the Center for Open Science (cos), and the Leibniz Institute for Psychology (ZPID), into the prereg package.

Copy link
Owner

@crsh crsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Lisa,

thanks or this. The template will be a great addtion to the package. In addition to my other comments, could you please

  • delete the file skeleton.pdf
  • add source information to template.yaml and the documentation of quantitative_research_in_psych_prereg (see some of the other templates for examples)?
  • maybe add a short-hand (alias) for quantitative_research_in_psych_prereg? Something along the lines of qrip_prereg? You can do this by making the following addition:
#' @describeIn quantitative_research_in_psych_prereg Alias of \code{quantitative_research_in_psych_prereg}.
#' @export

qrip_prereg <- function(...) {
  quantitative_research_in_psych_prereg(...)
}

@LisaSpitzerZPID
Copy link
Contributor Author

I solved some of the issues raised by crsh (thank you for your feedback!).
Yet, some things I still need to do:

  • I still need to work on the "header-includes" comment (as mentioned above, please specifiy how this needs to be done).
  • I still need to include the alias for "quantitative_research_in_psych". My supervisor will contact the task force today to inquire about their preferred alias.

I will get back to you ASAP concerning these issues.

@LisaSpitzerZPID
Copy link
Contributor Author

I have edited the template based on the new comments made by crsh (thanks again!). Now the only thing that still needs to be done is the inclusion of the alias. As mentioned before, I will work on this as soon as the task force has given feedback on the alias.

@crsh
Copy link
Owner

crsh commented Nov 25, 2020

Great work. Once the task force has made a decision, this PR is ready to merge. I'll prepare a new CRAN release right after that.

@LisaSpitzerZPID
Copy link
Contributor Author

I finished the editing.

  • I added some minor edits based on spelling
  • I included the licensing information in the yaml (hope this is the right place for this?)
  • I included the alias (psyquant_prereg)
  • I included the task force in the acknowledgements (I hope it's okay I did this)

If you agree with these edits, I would be happy for you to prepare the CRAN release.

@crsh crsh merged commit 0b98703 into crsh:master Nov 26, 2020
@crsh
Copy link
Owner

crsh commented Nov 26, 2020

Excellent, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants