Use open source PIX runtime instead of NuGet pre-build. #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crud89
added
DX12 ❎
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
This PR updates the overlay port for WinPixEventRuntime to build the open sourced version instead of downloading the pre-build binary from NuGet. For now this only helps us with managing dependencies (see #85), however it may come in handy in the future, e.g., if we want to support statically linking to it.
Additionally, it is now possible to control emission of debug marker support using the
LITEFX_BUILD_SUPPORT_DEBUG_MARKERSoption, which is enabled by default for all debug presets. Note that for PIX to be linked, thepix-supportfeature must also be enabled. By default, it is only set for the x64 windows debug build. However, using those two options it is now possible to support debug markers in release builds. Note that the DirectX 12 backend always requires both prerequisites to be set, while for the Vulkan backend it is sufficient to enable debug marker support.Related issues
Partially resolves #85.