Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Win32 build errors. #134

Merged
merged 7 commits into from
Jul 15, 2024
Merged

Fix Win32 build errors. #134

merged 7 commits into from
Jul 15, 2024

Conversation

crud89
Copy link
Owner

@crud89 crud89 commented Jul 15, 2024

Describe the pull request

This PR fixes some issues with the x86 build, namely:

  • Properly prevents attempts to include pix3.h if not available (regression from Use open source PIX runtime instead of NuGet pre-build. #133).
  • Template resolution errors with exception constructors, if uint64_t is not natively available.
  • An occasion where nullptr was used instead of VK_NULL_HANDLE.
  • A generator issue causing access violation on x86 release builds.

Additionally, this PR forces the CI builds to use the release profile and removes the publish profiles.

@crud89 crud89 added Priority: High A high priority issue. Requirement An implementation is required before the next release. Build 🛠 Issues that involve the build process. labels Jul 15, 2024
@crud89 crud89 added this to the Alpha #04 milestone Jul 15, 2024
@crud89 crud89 self-assigned this Jul 15, 2024
@crud89 crud89 merged commit b1043f1 into main Jul 15, 2024
@crud89 crud89 deleted the x86-compat-fixes branch July 15, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build 🛠 Issues that involve the build process. Priority: High A high priority issue. Requirement An implementation is required before the next release.
Projects
Status: v0.4.1
Development

Successfully merging this pull request may close these issues.

1 participant