PR feedback

cruise-automation · Sep 18, 2024 · 7fc2f1b · 7fc2f1b
1 parent e965953
commit 7fc2f1b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/include/mlir-tcp/Dialect/IR/TcpEnums.td b/include/mlir-tcp/Dialect/IR/TcpEnums.td
@@ -34,8 +34,8 @@ def Tcp_SignednessAttr : EnumAttr<Tcp_Dialect, Tcp_Signedness, "signedness">;
 
 // TCP rounding mode
 def Tcp_RoundingMode_Trunc : I32EnumAttrCase<"Trunc", 0>;
-def Tcp_RoundingMode_Floor   : I32EnumAttrCase<"Floor", 1>;
-def Tcp_RoundingMode_Ceil   : I32EnumAttrCase<"Ceil", 2>;
+def Tcp_RoundingMode_Floor : I32EnumAttrCase<"Floor", 1>;
+def Tcp_RoundingMode_Ceil  : I32EnumAttrCase<"Ceil", 2>;
 
 def Tcp_RoundingMode : I32EnumAttr<"RoundingMode",
     "Rounding mode for integer operations which need a rounding mode",

diff --git a/lib/Conversion/TcpToLinalg/Elementwise.cpp b/lib/Conversion/TcpToLinalg/Elementwise.cpp
@@ -203,7 +203,7 @@ createLinalgPayloadForElementwiseOp(Operation *op,
       return {b.create<arith::DivSIOp>(loc, payloadArgs[0], payloadArgs[1])};
     else if (divOp.getRoundingMode() == RoundingMode::Ceil)
       return {
-          b.create<arith::CeilDivUIOp>(loc, payloadArgs[0], payloadArgs[1])};
+          b.create<arith::CeilDivSIOp>(loc, payloadArgs[0], payloadArgs[1])};
     else
       return {
           b.create<arith::FloorDivSIOp>(loc, payloadArgs[0], payloadArgs[1])};