You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Curious, does this functionality need additional e2e tests in aot_compile or do existing tests already cover this op? If former, could you include e2e tests as well?
@sjain-stanford there is an e2e test for the index.Tensor_hacked_twin already. This PR changes the index.Tensor_hacked_twin to use tcp.gather_nd whereas before it was using tcp.gather. The reason for the change is that more complex indexing that is supported by index.Tensor_hacked_twin requires being able to gather over multiple dimensions at the same time. E.g. you can use index.Tensor_hacked_twin to select the diagonal of a matrix by doing something like x[torch.arange(x.shape[0]), torch.arange(x.shape[0])].
I will fix the nits that you pointed out. I am waiting to merge this PR as I would like to validate that the index.Tensor_hacked_twin change works but I am currently blocked by trt-mlir upgrade for testing the tcp.gather_nd. I already know that there needs to be some additional casting added to the index.Tensor_hacked_twin -> tcp.gather_nd to handle cases where different int types are used
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add tcp.gather_nd and rework index.Tensor_hacked_twin to use gather_nd