-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC + PR] Use TCP for {LLVM / Torch-MLIR / StableHLO} Green Commit Sync #11
[RFC + PR] Use TCP for {LLVM / Torch-MLIR / StableHLO} Green Commit Sync #11
Conversation
add llvm-project GHA badge to README
b95abe0
to
7a20a4b
Compare
path = local_stablehlo_repo_path(), | ||
) | ||
else: | ||
STABLEHLO_COMMIT = "5a8bb985f50a679721292b14f97f270344ac64a3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: we're bumping stablehlo commit here
# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
# Also available under a BSD-style license. See LICENSE. | ||
|
||
third_party/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is where local repos may be cloned
branches: | ||
- main | ||
paths: | ||
- 'deps.bzl' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is so the workflow is triggered only when change is made to deps.bzl
, as otherwise we shouldn't have to re-run a workflow (3p test status shouldn't change)
@@ -23,7 +25,7 @@ concurrency: | |||
|
|||
jobs: | |||
ubuntu-build: | |||
name: ubuntu-x86_64 | |||
name: ubuntu-x86_64 / mlir-tcp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the name change allows selectively making certain workflows merge gating
@@ -0,0 +1,145 @@ | |||
diff --git a/BUILD.bazel b/BUILD.bazel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is needed to be able to bazel test @stablehlo//...
from mlir-tcp
(can be removed once openxla/stablehlo#1810 lands)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Updates mlir-tcp to `90768ec2801ed9959144e8a1ca800e34ee2c7f54` resolves some minor merge conflicts around testing changes in [this PR](cruise-automation#28).
Why
When bumping LLVM up, it is crucial to be able to test all downstream repos depending on it to ensure they work in tandem (and not just in isolation).
In the past, LLVM upgrades were simpler because torch-mlir took a hard dependency on mhlo/stablehlo and, in doing so, ensured that the llvm "green commit" (sha1) that torch-mlir and stablehlo were built+tested against was pre-identified. During this time mlir-tcp was developed on a branch of torch-mlir.
This meant when upgrades were needed downstream, we’d simply point to torch-mlir@HEAD (sha4) and pick the llvm-project (sha1) and mhlo/stablehlo (sha3) hashes it’d refer to, since these are already tested to work together. This became our set of green commits (llvm@sha1, stablehlo@sha3, torch-mlir@sha4) for downstream integrations (e.g cruise monorepo).
At present the situation is complicated because torch-mlir no longer takes a hard dependency on stablehlo (stablehlo e2e tests disabled).
Here's details from a recent upgrade scenario that motivated this RFC.
We picked torch-mlir@HEAD which was right after the llvm bump in llvm/torch-mlir#2511 pointing to llvm/llvm-project@b44b349, but soon realized (when we started building torch-mlir) that the llvm bazel build upstream was broken:
The bazel fixes followed in a subsequent commit at llvm/llvm-project@28b27c1. Hence llvm had to be re-bumped in torch-mlir (llvm/torch-mlir#2517). However, after a bit more work we hit these failing stablehlo tests, which surfaced the fact that stablehlo pointed to by torch-mlir could no longer be used, and we had to separately identify the sha3 of stablehlo that would build cleanly against sha1 of llvm.
This meant the burden of identifying the llvm green commit (that works across the board) is shifted further downstream from torch-mlir. Incidentally we are in a great position to leverage mlir-tcp to identify the set of green commits, given it already directly depends on each of these repos.
What
This PR is an attempt to leverage the mlir-tcp repo as our "proxy" for such downstream integrations, and I think contains everything needed to be able to do that.
How
Specifically, we should now be able to run these from the comfort of
mlir-tcp
:We provide
local_repos.bzl
that allows easier local testing of patches that later need to be upstreamed, and while they're being upstreamed we could land them as patches to ourhttp_archive
targets.Note: I include a
stablehlo.patch
that allows testing stablehlo frommlir-tcp
. This is temporary and can be removed once openxla/stablehlo#1810 lands.This PR also enables each of the 3p test suites as GHA workflows (non-merge gating for now, we can change this). These workflows are automatically skipped unless a change is made to
deps.bzl
(which usually means bumping 3p deps), as it would be unnecessary to run them for every PR andmain
commit post-merge.Here's a snapshot from this PR's workflows, having bumped stablehlo commit.