[Dialect] Traits and type parser/printer fixes to unblock downstream integrations #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjain-stanford
changed the title
sjain-stanford
changed the title
navahgar
approved these changes
Oct 26, 2023
Comment on lines
18
to
25
| //===----------------------------------------------------------------------===// | ||
| // Tcp Type Definitions. | ||
| // Tcp Type Definitions | ||
| //===----------------------------------------------------------------------===// | ||
|
|
||
| def Tcp_IndexArrayType : Tcp_Type<"IndexArray", "index_array"> { | ||
| let summary = "IndexArray TCP type, to holds a list of index builtin type to represent shape"; | ||
| } | ||
|
|
There was a problem hiding this comment.
very minor nit: It might be better to have the basic types, Tcp_Scalar, Tcp_Tensor before we define IndexArrayType. The same would apply to the Tcp_QuantizedType as well. So, may be we can do it later.
There was a problem hiding this comment.
Tcp_Scalar depends on Tcp_QuantizedInt so it has to follow quantized types. However I've moved Tcp_IndexArrayType to the end.
sjain-stanford
changed the title
srinathava
pushed a commit
to srinathava/mlir-tcp
that referenced
this pull request
Jun 24, 2024
) Cherry-pick from upstream PR: cruise-automation#39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
error: 'tcp.isolated_group' op expects parent op to be one of 'func.func, tcp.group, tcp.isolated_group'error: dialect 'tcp' provides no type parsing hookTcp_IndexArrayTypedefinitionld.lld: error: undefined symbol: mlir::tcp::TcpDialect::printType(mlir::Type, mlir::DialectAsmPrinter&) constreferenced by TcpDialect.cpp