Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add scatter to tcp custom op #95

Merged
merged 2 commits into from
Sep 6, 2024
Merged

add scatter to tcp custom op #95

merged 2 commits into from
Sep 6, 2024

Conversation

matthewfl
Copy link
Contributor

as titled

@matthewfl matthewfl requested a review from zezhang September 5, 2024 21:19
sjain-stanford
sjain-stanford reviewed Sep 5, 2024
View reviewed changes
Copy link
Collaborator

@sjain-stanford sjain-stanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a lit test.

zezhang
zezhang approved these changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@zezhang zezhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matthewfl matthewfl changed the title add scater to tcp custom op add scatter to tcp custom op Sep 6, 2024
@matthewfl matthewfl merged commit 36418dc into cruise-automation:main Sep 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjain-stanford sjain-stanford sjain-stanford left review comments

@zezhang zezhang zezhang approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matthewfl @zezhang @sjain-stanford