Add converter for index.Tensor_hacked_twin #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zezhang
reviewed
Sep 18, 2024
There was a problem hiding this comment.
LGTM! Can we also try to add it to the aot_compile test suite for e2e coverage?
| %int1 = torch.constant.int 1 | ||
| %int4 = torch.constant.int 4 // this is a dtype on arange.... | ||
| %int-1 = torch.constant.int -1 | ||
| %arange = torch.aten.arange.start_step %int0, %int1, %int1, %int4, %none, %none, %none : !torch.int, !torch.int, !torch.int, !torch.int, !torch.none, !torch.none, !torch.none -> !torch.vtensor<[1],si64> |
There was a problem hiding this comment.
torch.aten.arange.start_step will remain unchanged right? As we don't handle it in tcp.
There was a problem hiding this comment.
Currently this remains unchanged. I was thinking that we should add an optimization pass that removes this when it selects everything, but I have yet to do that
navahgar
reviewed
Sep 20, 2024
…so gather custom op seems to be required
navahgar
approved these changes
Sep 20, 2024
zezhang
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tcp.custom_opvariants ofTensor_hacked_twintcp.gatherandtcp.constto ensure that is used correctly