Re-throw PreRunValidationExceptions to the user

When no Exception is thrown, the user could think it was a successful
crawler run, without looking at the log messages, so re-throw it to the
user.

CHANGELOG.md

@@ -6,7 +6,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
-## [2.0.0] - 2024-x-x
+## [2.0.0] - 2024-10-11
 ### Changed
 * __BREAKING__: Removed methods `BaseStep::addToResult()`, `BaseStep::addLaterToResult()`, `BaseStep::addsToOrCreatesResult()`, `BaseStep::createsResult()`, and `BaseStep::keepInputData()`. These methods were deprecated in v1.8.0 and should be replaced with `Step::keep()`, `Step::keepAs()`, `Step::keepFromInput()`, and `Step::keepInputAs()`.
 * __BREAKING__: Added the following keep methods to the `StepInterface`: `StepInterface::keep()`, `StepInterface::keepAs()`, `StepInterface::keepFromInput()`, `StepInterface::keepInputAs()`, as well as `StepInterface::keepsAnything()`, `StepInterface::keepsAnythingFromInputData()` and `StepInterface::keepsAnythingFromOutputData()`. If you have a class that implements this interface without extending `Step` (or `BaseStep`), you will need to implement these methods yourself. However, it is strongly recommended to extend `Step` instead.
@@ -24,13 +24,15 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 * __BREAKING__: Removed method `RespondedRequest::cacheKeyFromRequest()`. Use `RequestKey::from()` instead.
 * __BREAKING__: The `HttpLoader::retryCachedErrorResponses()` method now returns an instance of the new `Crwlr\Crawler\Loader\Http\Cache\RetryManager` class. This class provides the methods `only()` and `except()` to restrict retries to specific HTTP response status codes. Previously, this method returned the `HttpLoader` itself (`$this`), so if you're using it in a chain and calling other loader methods after it, you will need to refactor your code.
 * __BREAKING__: Removed the `Microseconds` class from this package. It has been moved to the `crwlr/utils` package, which you can use instead.
+* __BREAKING__: When a 
 
 ### Added
 * New methods `FileCache::prolong()` and `FileCache::prolongAll()` to allow prolonging the time to live for cached responses.
 
 ### Fixed
 * The `maxOutputs()` method is now also available and working on `Group` steps.
 * Improved warning messages for step validations that are happening before running a crawler.
+* A `PreRunValidationException` when the crawler finds a problem with the setup, before actually running, is not only logged as an error via the logger, but also rethrown to the user. This way the user won't get the impression, that the crawler ran successfully without looking at the log messages.
 
 ## [1.10.0] - 2024-08-05
 ### Added

src/Crawler.php

@@ -202,9 +202,7 @@ public function runAndDump(): void
      */
     public function run(): Generator
     {
-        if (!$this->validateSteps()) {
-            return;
-        }
+        $this->validateSteps();
 
         $inputs = $this->prepareInput();
 
@@ -311,7 +309,7 @@ protected function storeAndReturnOutputsAsResults(Generator $outputs): Generator
     /**
      * @throws PreRunValidationException
      */
-    protected function validateSteps(): bool
+    protected function validateSteps(): void
     {
         $previousStep = null;
 
@@ -328,12 +326,10 @@ protected function validateSteps(): bool
                         'Pre-Run validation error in step number ' . ($index + 1) . ': ' . $exception->getMessage(),
                     );
 
-                    return false;
+                    throw $exception;
                 }
             }
         }
-
-        return true;
     }
 
     /**

tests/CrawlerTest.php

@@ -2,6 +2,7 @@
 
 namespace tests;
 
+use Crwlr\Crawler\Steps\Exceptions\PreRunValidationException;
 use Crwlr\Crawler\Steps\StepOutputType;
 use tests\_Stubs\Crawlers\DummyOne;
 use tests\_Stubs\Crawlers\DummyTwo;
@@ -313,11 +314,15 @@ public function outputType(): StepOutputType
         ->addStep($step1->keep())
         ->addStep($step2->keep());
 
-    $results = iterator_to_array($crawler->run());
+    try {
+        $results = iterator_to_array($crawler->run());
+    } catch (PreRunValidationException $exception) {
+    }
 
-    expect($results)->toBeEmpty()
+    expect($results ?? null)->toBeEmpty()
         ->and($step1->wasCalled)->toBeFalse()
-        ->and($this->getActualOutputForAssertion())->toContain('Pre-Run validation error in step number 2');
+        ->and($this->getActualOutputForAssertion())->toContain('Pre-Run validation error in step number 2')
+        ->and($exception ?? null)->toBeInstanceOf(PreRunValidationException::class);
 });
 
 it('sends all results to the Store when there is one and still yields the results', function () {