Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: support ethermint ExtensionOptionDynamicFeeTx msg type #750

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

Problem: support ethermint ExtensionOptionDynamicFeeTx msg type #750

wants to merge 20 commits into from

Conversation

vincentysc
Copy link
Contributor

No description provided.

calvinaco
calvinaco requested changes Sep 19, 2022
View reviewed changes
Copy link
Collaborator

@calvinaco calvinaco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments. The test case seems failing as well. Thanks.

usecase/command/create_msg_extension_option_dynamic_fee_tx..go Outdated Show resolved Hide resolved
usecase/parser/msg.go Outdated Show resolved Hide resolved
usecase/parser/msg.go Outdated Show resolved Hide resolved
usecase/parser/msg.go Outdated Show resolved Hide resolved
usecase/parser/msg.go Outdated Show resolved Hide resolved
usecase/parser/msg.go Outdated Show resolved Hide resolved
@vincentysc
Copy link
Contributor Author

vincentysc commented Sep 19, 2022 •
edited
Loading

Left some comments. The test case seems failing as well. Thanks.

Thanks, I think we need to have an inner parser for legacyTx, DynamicFeeTx type on Ethermint Transaction. So, will update it.

davcrypto
davcrypto reviewed Sep 20, 2022
View reviewed changes
usecase/parser/msg.go Outdated Show resolved Hide resolved
@vincentysc vincentysc linked an issue Sep 20, 2022 that may be closed by this pull request
Problem: support ethermint ExtensionOptionDynamicFeeTx msg type #748
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davcrypto davcrypto davcrypto left review comments

@calvinaco calvinaco Awaiting requested review from calvinaco calvinaco is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problem: support ethermint ExtensionOptionDynamicFeeTx msg type
3 participants
@vincentysc @calvinaco @davcrypto