Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: overwrite in edit_app_cfg is not correct #114

Closed
wants to merge 2 commits into from
Closed

Problem: overwrite in edit_app_cfg is not correct #114

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dec862e
Problem: overwrite in edit_app_cfg is not correct
mmsqe Jan 17, 2024
da552d0
Update CHANGELOG.md
mmsqe Jan 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
- [#110](https://github.com/crypto-com/pystarport/pull/110) add event_query_tx_for to allow subscribe and wait for transaction.
- [#112](https://github.com/crypto-com/pystarport/pull/112) add cmd for migrate keystore.
- [#113](https://github.com/crypto-com/pystarport/pull/113) support ibc related cmd.
- [#](https://github.com/crypto-com/pystarport/pull/) remove extra overwrite in edit_app_cfg.
mmsqe marked this conversation as resolved.
Show resolved Hide resolved


*Feb 7, 2023*
Expand Down
6 changes: 0 additions & 6 deletions pystarport/cluster.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1284,12 +1284,6 @@ def edit_app_cfg(path, base_port, app_config):
"grpc": {
"address": "127.0.0.1:%d" % ports.grpc_port(base_port),
},
"pruning": "nothing",
"state-sync": {
"snapshot-interval": 5,
"snapshot-keep-recent": 10,
},
"minimum-gas-prices": "0basecro",
}

app_config = format_value(
Expand Down
Loading