This repository has been archived by the owner on Jul 27, 2022. It is now read-only.
Problem: tdbe types are not up to date with latest design (fixes #1967) #1977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomtau
requested review from
yihuang,
devashishdxt,
leejw51crypto and
linfeng-crypto
devashishdxt
approved these changes
Jul 22, 2020
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jul 22, 2020
1977: Problem: tdbe types are not up to date with latest design (fixes #1967) r=tomtau a=tomtau Solution: updated the data types according to the latest doc https://github.com/crypto-com/chain-docs/pull/179/files - chain-abci part was moved to extras module of mls for validation (when crypto-org-chain/chain-docs#141 is done implementation could go there) - in order not to break tx format, confidential init is still takes as Vec<u8> - as tdbe workflows aren't ready yet, a temporary wrapper was put in the client Co-authored-by: Tomas Tauber <[email protected]>
tomtau
force-pushed
the
update/tdbe-types
branch
from
f9d96d1 to
169e9bb
Compare
|
bors r- |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jul 22, 2020
1977: Problem: tdbe types are not up to date with latest design (fixes #1967) r=tomtau a=tomtau Solution: updated the data types according to the latest doc https://github.com/crypto-com/chain-docs/pull/179/files - chain-abci part was moved to extras module of mls for validation (when crypto-org-chain/chain-docs#141 is done implementation could go there) - in order not to break tx format, confidential init is still takes as Vec<u8> - as tdbe workflows aren't ready yet, a temporary wrapper was put in the client Co-authored-by: Tomas Tauber <[email protected]>
|
Build failed: |
tomtau
force-pushed
the
update/tdbe-types
branch
from
169e9bb to
5a3a3d9
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jul 22, 2020
1977: Problem: tdbe types are not up to date with latest design (fixes #1967) r=tomtau a=tomtau Solution: updated the data types according to the latest doc https://github.com/crypto-com/chain-docs/pull/179/files - chain-abci part was moved to extras module of mls for validation (when crypto-org-chain/chain-docs#141 is done implementation could go there) - in order not to break tx format, confidential init is still takes as Vec<u8> - as tdbe workflows aren't ready yet, a temporary wrapper was put in the client Co-authored-by: Tomas Tauber <[email protected]>
tomtau
force-pushed
the
update/tdbe-types
branch
2 times, most recently
from
a5a5b2d to
961b12d
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jul 22, 2020
1977: Problem: tdbe types are not up to date with latest design (fixes #1967) r=tomtau a=tomtau Solution: updated the data types according to the latest doc https://github.com/crypto-com/chain-docs/pull/179/files - chain-abci part was moved to extras module of mls for validation (when crypto-org-chain/chain-docs#141 is done implementation could go there) - in order not to break tx format, confidential init is still takes as Vec<u8> - as tdbe workflows aren't ready yet, a temporary wrapper was put in the client Co-authored-by: Tomas Tauber <[email protected]>
|
Build failed: |
…to-com#1967) Solution: updated the data types according to the latest doc https://github.com/crypto-com/chain-docs/pull/179/files - chain-abci part was moved to extras module of mls for validation (when crypto-org-chain/chain-docs#141 is done implementation could go there) - in order not to break tx format, confidential init is still takes as Vec<u8> - as tdbe workflows aren't ready yet, a temporary wrapper was put in the client
tomtau
force-pushed
the
update/tdbe-types
branch
from
961b12d to
f0c4528
Compare
|
bors retry |
|
Build succeeded: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution: updated the data types according to the latest
doc https://github.com/crypto-com/chain-docs/pull/179/files
(when Mainnet docs Seeds Update crypto-org-chain/chain-docs#141 is done
implementation could go there)