Security: Remove web3 v1.x #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #420 +/- ##
==========================================
+ Coverage 98.02% 98.04% +0.02%
==========================================
Files 161 161
Lines 7596 7682 +86
Branches 571 588 +17
==========================================
+ Hits 7446 7532 +86
Misses 150 150 ☔ View full report in Codecov by Sentry. |
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/[email protected], npm/[email protected] |
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
davcrypto
approved these changes
Jun 7, 2024
davcrypto
approved these changes
Jul 2, 2024
davcrypto
approved these changes
Jul 2, 2024
crypto-matto
commented
Jul 3, 2024
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@crypto-org-chain/chain-jslib", | |||
| "version": "1.1.2", | |||
| "version": "1.1.3", | |||
There was a problem hiding this comment.
It’s bumping from 1.1.2 to 1.1.3 already?
calvinaco
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason of Change
Remove any dependencies from
web3because v1 will be discontinued since July 1, 2024Reference: https://github.com/web3/web3.js/releases/tag/v1.10.4