Skip to content

Commit

Permalink
Problem: non-deterministic test_manual_upgrade_all integration test (#…
Browse files Browse the repository at this point in the history
…654)

Solution:
- upgraded dependencies + custom fork of Cosmos SDK which reduces sources of non-determinism in the upgrade module
- disabled `test_manual_upgrade`, as upgrade tests are executed on the same cluster and `test_manual_upgrade_all` executes `test_manual_upgrade` anyway.
  • Loading branch information
tomtau authored Sep 17, 2021
1 parent 3e19436 commit 5be29fa
Show file tree
Hide file tree
Showing 5 changed files with 1,922 additions and 171 deletions.
18 changes: 16 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,14 +1,28 @@
# Changelog

*Septeber 7, 2021*
*September 17, 2021*

## v3.2.0-rc0
This version is identical to the v3.1.1, but did the following dependency upgrades:
- ibc-go was upgraded to 1.2.0
- tendermint was upgraded to v0.34.13
- Cosmos SDK was patched with a custom fork based off the upstream 0.44.x release branch: https://github.com/crypto-org-chain/cosmos-sdk/tree/0.44.x-patched .

The upstream 0.44.x release branch contains several bug fixes from the 0.44.0.
The custom patch mitigates potential sources of non-determinism in the Cosmos SDK's upgrade module: https://github.com/crypto-org-chain/cosmos-sdk/commit/00ffa3d5a00b83d52072397e348e36b8398f0b7b

*WARNING*: DO NOT upgrade to this binary yet; instructions are going to be published later
on https://crypto.org/docs/getting-started/upgrade_guide.html .

*September 7, 2021*

## v3.1.1
This version is identical to the v3.1.0, but updated the ibc-go dependency to 1.1.0.
*WARNING*: DO NOT upgrade to this binary yet; instructions are going to be published later
on https://crypto.org/docs/getting-started/upgrade_guide.html .


*Septeber 2, 2021*
*September 2, 2021*

## v3.1.0
This version is identical to the v3.0.1, but updated the Cosmos SDK dependency to 0.44.0 which contains a consensus-breaking security patch.
Expand Down
11 changes: 7 additions & 4 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ go 1.16
require (
github.com/confluentinc/bincover v0.1.0
github.com/cosmos/cosmos-sdk v0.44.0
github.com/cosmos/ibc-go v1.1.0
github.com/cosmos/ibc-go v1.2.0
github.com/cosmos/ledger-go v0.9.2 // indirect
github.com/gogo/protobuf v1.3.3
github.com/golang/protobuf v1.5.2
Expand All @@ -15,14 +15,14 @@ require (
github.com/imdario/mergo v0.3.11
github.com/rakyll/statik v0.1.7
github.com/spf13/cast v1.3.1
github.com/spf13/cobra v1.1.3
github.com/spf13/cobra v1.2.1
github.com/spf13/pflag v1.0.5
github.com/stretchr/testify v1.7.0
github.com/tendermint/tendermint v0.34.12
github.com/tendermint/tendermint v0.34.13
github.com/tendermint/tm-db v0.6.4
github.com/tidwall/gjson v1.7.5
google.golang.org/genproto v0.0.0-20210602131652-f16073e35f0c
google.golang.org/grpc v1.38.0
google.golang.org/grpc v1.40.0

)

Expand All @@ -37,3 +37,6 @@ replace github.com/cosmos/ledger-cosmos-go => github.com/crypto-com/ledger-cosmo
replace github.com/99designs/keyring => github.com/crypto-org-chain/keyring v1.1.6-fixes

replace github.com/dgrijalva/jwt-go => github.com/dgrijalva/jwt-go/v4 v4.0.0-preview1

// FIXME: back to upstream release once upgrade non-determinism is gone
replace github.com/cosmos/cosmos-sdk => github.com/crypto-org-chain/cosmos-sdk v0.44.0-upgradefix
Loading

0 comments on commit 5be29fa

Please sign in to comment.