-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: update voting_period is not tested #1017
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1017 +/- ##
=======================================
Coverage 34.34% 34.34%
=======================================
Files 93 93
Lines 14105 14105
=======================================
Hits 4844 4844
Misses 8319 8319
Partials 942 942
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mmsqe
force-pushed
the
test_voting_period
branch
from
October 26, 2023 02:53
d10bca4
to
be0a6ca
Compare
mmsqe
force-pushed
the
test_voting_period
branch
from
October 26, 2023 03:51
11b0f9a
to
3428621
Compare
Signed-off-by: mmsqe <[email protected]>
Signed-off-by: yihuang <[email protected]>
yihuang
reviewed
Aug 15, 2024
yihuang
reviewed
Aug 15, 2024
Signed-off-by: yihuang <[email protected]>
yihuang
approved these changes
Aug 15, 2024
Merged
via the queue into
crypto-org-chain:master
with commit Aug 15, 2024
f26b2cc
30 of 32 checks passed
mmsqe
added a commit
to kaz-CDC/chain-main
that referenced
this pull request
Sep 6, 2024
* Problem: update voting_period is not tested * Apply suggestions from code review Signed-off-by: yihuang <[email protected]> * fix test --------- Signed-off-by: mmsqe <[email protected]> Signed-off-by: yihuang <[email protected]> Co-authored-by: yihuang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make
)make test
)go fmt
)golangci-lint run
)go list -json -m all | nancy sleuth
)Thank you for your code, it's appreciated! :)