Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: nixpkgs and python dependencies are out of date #1034

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Feb 21, 2024

Solution:

  • use go 1.22
  • update nixpkgs to nixpkgs-unstable
  • rustc to 1.75
  • update python dependencies in integration tests

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@yihuang yihuang requested a review from a team as a code owner February 21, 2024 01:46
Copy link

socket-security bot commented Feb 21, 2024

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected], pypi/[email protected]

View full report↗︎

@yihuang yihuang requested a review from mmsqe February 21, 2024 01:48
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (c0436a5) 30.08% compared to head (4f2481e) 32.92%.

Files Patch % Lines
app/test_helpers.go 0.00% 7 Missing ⚠️
x/nft/simulation/operations.go 0.00% 7 Missing ⚠️
x/chainmain/client/cli/testnet.go 50.00% 2 Missing ⚠️
cmd/chain-maind/app/app.go 75.00% 1 Missing ⚠️
x/icaauth/types/params.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1034      +/-   ##
==========================================
+ Coverage   30.08%   32.92%   +2.84%     
==========================================
  Files         125      131       +6     
  Lines       20039    20164     +125     
==========================================
+ Hits         6028     6640     +612     
+ Misses      12965    12461     -504     
- Partials     1046     1063      +17     
Flag Coverage Δ
integration_tests 20.61% <71.42%> (-0.10%) ⬇️
integration_tests_byzantine 9.55% <58.73%> (-0.11%) ⬇️
integration_tests_gov 9.92% <58.73%> (-0.11%) ⬇️
integration_tests_grpc 9.90% <58.73%> (-0.11%) ⬇️
integration_tests_ibc 24.71% <71.42%> (-0.10%) ⬇️
integration_tests_ledger 9.79% <58.73%> (-0.11%) ⬇️
integration_tests_slow 9.79% <58.73%> (-0.11%) ⬇️
integration_tests_solomachine 9.58% <58.73%> (-0.11%) ⬇️
integration_tests_upgrade 9.90% <58.73%> (-0.11%) ⬇️
unit_tests 10.60% <58.92%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mmsqe mmsqe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need update go.mod and cleanup unused GOLANG_CROSS_VERSION?

@mmsqe
Copy link
Contributor

mmsqe commented Feb 21, 2024

do we need bump chainlibpy as well?

@yihuang yihuang requested a review from mmsqe February 21, 2024 04:57
app/app.go Outdated Show resolved Hide resolved
app/app.go Outdated Show resolved Hide resolved
@yihuang
Copy link
Collaborator Author

yihuang commented Feb 21, 2024

do we need bump chainlibpy as well?

it seems easier to refactor the test case itself.

Solution:
- update nixpkgs to nixpkgs-unstable
- rustc to 1.75
- update python dependencies in integration tests

update go in workflows

fix hdwallets

trigger build, don't merge

release workflow

update govuln

update go.mod

fix go.mod

add toolchain

bump golangci-lint

fix go lint

fix nix lint

Update app/app.go

Signed-off-by: yihuang <[email protected]>

skip test_sign_offline for now

fix skip

fix ledger test

fix py lint

align version

fix lint
@yihuang yihuang enabled auto-merge February 21, 2024 08:55
@yihuang yihuang added this pull request to the merge queue Feb 21, 2024
Merged via the queue into crypto-org-chain:master with commit e344315 Feb 21, 2024
33 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants