-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: nixpkgs and python dependencies are out of date #1034
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1034 +/- ##
==========================================
+ Coverage 30.08% 32.92% +2.84%
==========================================
Files 125 131 +6
Lines 20039 20164 +125
==========================================
+ Hits 6028 6640 +612
+ Misses 12965 12461 -504
- Partials 1046 1063 +17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need update go.mod and cleanup unused GOLANG_CROSS_VERSION?
do we need bump chainlibpy as well? |
it seems easier to refactor the test case itself. |
Solution: - update nixpkgs to nixpkgs-unstable - rustc to 1.75 - update python dependencies in integration tests update go in workflows fix hdwallets trigger build, don't merge release workflow update govuln update go.mod fix go.mod add toolchain bump golangci-lint fix go lint fix nix lint Update app/app.go Signed-off-by: yihuang <[email protected]> skip test_sign_offline for now fix skip fix ledger test fix py lint align version fix lint
e344315
Solution:
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make
)make test
)go fmt
)golangci-lint run
)go list -json -m all | nancy sleuth
)Thank you for your code, it's appreciated! :)