Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: statik bring big binary size diff #1035

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

mmsqe
Copy link
Contributor

@mmsqe mmsqe commented Feb 23, 2024

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@mmsqe mmsqe requested a review from a team as a code owner February 23, 2024 04:07
@mmsqe mmsqe enabled auto-merge February 23, 2024 04:09
Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.91%. Comparing base (e344315) to head (cdce3a1).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1035      +/-   ##
==========================================
- Coverage   32.92%   32.91%   -0.01%     
==========================================
  Files         131      130       -1     
  Lines       20164    20161       -3     
==========================================
- Hits         6640     6637       -3     
  Misses      12461    12461              
  Partials     1063     1063              
Flag Coverage Δ
integration_tests 20.60% <100.00%> (-0.02%) ⬇️
integration_tests_byzantine 9.54% <100.00%> (-0.02%) ⬇️
integration_tests_gov 9.90% <100.00%> (-0.02%) ⬇️
integration_tests_grpc 9.88% <100.00%> (-0.02%) ⬇️
integration_tests_ibc 24.70% <100.00%> (-0.02%) ⬇️
integration_tests_ledger 9.77% <100.00%> (-0.02%) ⬇️
integration_tests_slow 9.77% <100.00%> (-0.02%) ⬇️
integration_tests_solomachine 9.57% <100.00%> (-0.02%) ⬇️
integration_tests_upgrade 9.88% <100.00%> (-0.02%) ⬇️
unit_tests 10.59% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmsqe mmsqe added this pull request to the merge queue Feb 23, 2024
Merged via the queue into crypto-org-chain:master with commit 911b8a5 Feb 23, 2024
32 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants