Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: minor security issue in github workflow #1072

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Jul 31, 2024

๐Ÿ‘ฎ๐Ÿป๐Ÿ‘ฎ๐Ÿป๐Ÿ‘ฎ๐Ÿป !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! ๐Ÿ‘ฎ๐Ÿป๐Ÿ‘ฎ๐Ÿป๐Ÿ‘ฎ๐Ÿป

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@yihuang yihuang requested a review from a team as a code owner July 31, 2024 03:10
@yihuang
Copy link
Collaborator Author

yihuang commented Jul 31, 2024

/runsim

Copy link

Simulation tests started and triggered by /runsim.
Will update here when it succeeds or fails.
Can further check progress here

@yihuang
Copy link
Collaborator Author

yihuang commented Jul 31, 2024

/runsim

Copy link

Simulation tests started and triggered by /runsim.
Will update here when it succeeds or fails.
Can further check progress here

Copy link

codecov bot commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests โœ…

Project coverage is 34.34%. Comparing base (1baff8a) to head (4714f67).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1072      +/-   ##
==========================================
- Coverage   36.55%   34.34%   -2.21%     
==========================================
  Files         101       93       -8     
  Lines       14350    14105     -245     
==========================================
- Hits         5245     4844     -401     
- Misses       8158     8319     +161     
+ Partials      947      942       -5     
Flag Coverage ฮ”
integration_tests 25.79% <รธ> (รธ)
integration_tests_byzantine 11.27% <รธ> (รธ)
integration_tests_gov 11.54% <รธ> (รธ)
integration_tests_grpc 11.54% <รธ> (รธ)
integration_tests_ibc 27.52% <รธ> (รธ)
integration_tests_ledger 11.53% <รธ> (รธ)
integration_tests_slow 11.53% <รธ> (รธ)
integration_tests_solomachine 11.32% <รธ> (รธ)
integration_tests_upgrade 11.54% <รธ> (รธ)
unit_tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

@yihuang yihuang requested a review from mmsqe July 31, 2024 03:18
Copy link

โœ… /runsim simulation test has succeeded ๐ŸŽ‰
Can further check here

Copy link

โœ… /runsim simulation test has succeeded ๐ŸŽ‰
Can further check here

@yihuang yihuang added this pull request to the merge queue Jul 31, 2024
Merged via the queue into crypto-org-chain:master with commit 0bcc269 Jul 31, 2024
29 of 32 checks passed
@yihuang yihuang deleted the fix-workflow branch July 31, 2024 04:42
mmsqe pushed a commit to kaz-CDC/chain-main that referenced this pull request Sep 6, 2024
* Problem: minor security issue in github workflow

* fix PR_PUSHED_AT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants