Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix some comments #1074

Merged
merged 2 commits into from
Aug 19, 2024
Merged

chore: fix some comments #1074

merged 2 commits into from
Aug 19, 2024

Conversation

pengbanban
Copy link
Contributor

fix some comments

@pengbanban pengbanban requested a review from a team as a code owner August 4, 2024 11:33
@yihuang
Copy link
Collaborator

yihuang commented Aug 4, 2024

thanks, can you sign the commit?

Signed-off-by: pengbanban <[email protected]>
@pengbanban
Copy link
Contributor Author

thanks, can you sign the commit?

Of course. Signed.

Sorry for waiting so long.

@mmsqe mmsqe enabled auto-merge August 19, 2024 01:08
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 36.55%. Comparing base (f26b2cc) to head (5fc7c4e).
Report is 1 commits behind head on master.

Files Patch % Lines
app/app.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1074      +/-   ##
==========================================
+ Coverage   34.34%   36.55%   +2.20%     
==========================================
  Files          93      101       +8     
  Lines       14105    14350     +245     
==========================================
+ Hits         4844     5245     +401     
+ Misses       8319     8158     -161     
- Partials      942      947       +5     
Flag Coverage Δ
integration_tests 25.79% <0.00%> (ø)
integration_tests_byzantine 11.27% <0.00%> (ø)
integration_tests_gov 11.54% <0.00%> (ø)
integration_tests_grpc 11.54% <0.00%> (ø)
integration_tests_ibc 27.52% <0.00%> (ø)
integration_tests_ledger 11.53% <0.00%> (ø)
integration_tests_slow 11.53% <0.00%> (ø)
integration_tests_solomachine 11.32% <0.00%> (ø)
integration_tests_upgrade ?
unit_tests 11.86% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmsqe mmsqe added this pull request to the merge queue Aug 19, 2024
Merged via the queue into crypto-org-chain:master with commit 57a34d6 Aug 19, 2024
30 of 35 checks passed
mmsqe added a commit to kaz-CDC/chain-main that referenced this pull request Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants