Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: security patch from cosmos sdk is not included #1097

Merged
merged 5 commits into from
Dec 18, 2024

Conversation

mmsqe
Copy link
Contributor

@mmsqe mmsqe commented Dec 18, 2024

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

for more info

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@mmsqe mmsqe requested a review from a team as a code owner December 18, 2024 07:08
mmsqe and others added 4 commits December 18, 2024 15:18
…rypto-org-chain#1090)

* Problem: persist-credentials might leak github token unintentionally

Solution:
- try persist-credentials: false

* refresh

---------

Signed-off-by: yihuang <[email protected]>
Co-authored-by: mmsqe <[email protected]>
@mmsqe mmsqe merged commit 5800739 into crypto-org-chain:release/v4 Dec 18, 2024
19 of 20 checks passed
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 20.71%. Comparing base (5d52377) to head (8eb7fd1).
Report is 6 commits behind head on release/v4.

❗ There is a different number of reports uploaded between BASE (5d52377) and HEAD (8eb7fd1). Click for more details.

HEAD has 14 uploads less than BASE
Flag BASE (5d52377) HEAD (8eb7fd1)
integration_tests_solomachine 2 0
integration_tests_grpc 2 0
unit_tests 1 0
integration_tests_slow 2 1
integration_tests_ledger 2 1
integration_tests_byzantine 2 1
integration_tests_gov 2 1
integration_tests 2 1
integration_tests_ibc 2 0
integration_tests_upgrade 2 0
Additional details and impacted files
@@               Coverage Diff               @@
##           release/v4    #1097       +/-   ##
===============================================
- Coverage       33.08%   20.71%   -12.38%     
===============================================
  Files             127      126        -1     
  Lines           20043    20041        -2     
===============================================
- Hits             6631     4151     -2480     
- Misses          12351    15273     +2922     
+ Partials         1061      617      -444     
Flag Coverage Δ
integration_tests 20.71% <ø> (ø)
integration_tests_byzantine 9.66% <ø> (ø)
integration_tests_gov 10.02% <ø> (ø)
integration_tests_grpc ?
integration_tests_ibc ?
integration_tests_ledger 9.89% <ø> (ø)
integration_tests_slow 9.89% <ø> (ø)
integration_tests_solomachine ?
integration_tests_upgrade ?
unit_tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants