Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: introduce PreBlock #186

Merged
merged 25 commits into from
Sep 5, 2023
Merged

feat: introduce PreBlock #186

merged 25 commits into from
Sep 5, 2023

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Aug 16, 2023

Description

Closes: #XXXX

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@mmsqe mmsqe requested a review from yihuang August 16, 2023 04:22
yihuang
yihuang reviewed Aug 16, 2023
View reviewed changes
baseapp/baseapp.go Outdated Show resolved Hide resolved
yihuang
yihuang reviewed Aug 16, 2023
View reviewed changes
baseapp/abci.go Outdated Show resolved Hide resolved
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 16, 2023
View reviewed changes
baseapp/abci.go Fixed Show fixed Hide fixed
baseapp/abci.go Fixed Show fixed Hide fixed
types/module/module.go Fixed Show fixed Hide fixed
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 16, 2023
View reviewed changes
baseapp/abci.go Fixed Show fixed Hide fixed
yihuang
yihuang reviewed Aug 16, 2023
View reviewed changes
baseapp/abci.go Outdated Show resolved Hide resolved
yihuang
yihuang reviewed Aug 16, 2023
View reviewed changes
baseapp/abci.go Outdated Show resolved Hide resolved
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 16, 2023
View reviewed changes
baseapp/abci.go Fixed Show fixed Hide fixed
baseapp/abci.go Fixed Show fixed Hide fixed
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 16, 2023
View reviewed changes
baseapp/abci.go Fixed Show fixed Hide fixed
baseapp/abci.go Fixed Show fixed Hide fixed
baseapp/abci.go Fixed Show fixed Hide fixed
yihuang
yihuang reviewed Aug 16, 2023
View reviewed changes
types/module/module.go Outdated Show resolved Hide resolved
yihuang
yihuang reviewed Aug 16, 2023
View reviewed changes
types/module/module.go Outdated Show resolved Hide resolved
yihuang
yihuang reviewed Aug 16, 2023
View reviewed changes
simapp/app.go Outdated Show resolved Hide resolved
yihuang
yihuang reviewed Aug 16, 2023
View reviewed changes
baseapp/abci.go Outdated Show resolved Hide resolved
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 17, 2023
View reviewed changes
baseapp/abci.go Fixed Show fixed Hide fixed
baseapp/abci.go Fixed Show fixed Hide fixed
yihuang
yihuang reviewed Aug 17, 2023
View reviewed changes
baseapp/abci.go Outdated Show resolved Hide resolved
yihuang
yihuang reviewed Aug 17, 2023
View reviewed changes
baseapp/abci.go Outdated Show resolved Hide resolved
yihuang
yihuang reviewed Aug 17, 2023
View reviewed changes
types/abci.go Outdated Show resolved Hide resolved
yihuang
yihuang reviewed Aug 17, 2023
View reviewed changes
types/abci.go Outdated Show resolved Hide resolved
yihuang
yihuang reviewed Aug 17, 2023
View reviewed changes
x/upgrade/module.go Outdated Show resolved Hide resolved
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 17, 2023
View reviewed changes
baseapp/abci.go Fixed Show fixed Hide fixed
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 21, 2023
View reviewed changes
baseapp/abci.go
if app.preBlocker != nil {
rsp, err := app.preBlocker(ctx, req)
if err != nil {
panic(fmt.Errorf("preBlock failed, height: %d, err: %w", req.Header.Height, err))

Check warning

Code scanning / CodeQL

Panic in BeginBock or EndBlock consensus methods

path flow from Begin/EndBlock to a panic call
baseapp/abci.go
if app.preBlocker != nil {
rsp, err := app.preBlocker(ctx, req)
if err != nil {
panic(fmt.Errorf("preBlock failed, height: %d, err: %w", req.Header.Height, err))

Check warning

Code scanning / CodeQL

Panic in BeginBock or EndBlock consensus methods

Possible panics in BeginBock- or EndBlock-related consensus methods could cause a chain halt
@yihuang yihuang changed the title fix: Add MigrationModuleManager to handle migration of upgrade module before other modules feat: introduce PreBlock Aug 23, 2023
@mmsqe mmsqe requested a review from yihuang September 5, 2023 03:49
mmsqe and others added 25 commits September 5, 2023 12:04
@mmsqe
fix: Add MigrationModuleManager to handle migration of upgrade module…
44eb064 
… before other modules (cosmos#16583)

Co-authored-by: Aleksandr Bezobchuk <[email protected]>
Co-authored-by: Julien Robert <[email protected]>
(cherry picked from commit 0c1f6fc)

# Conflicts:
#	CHANGELOG.md
#	UPGRADING.md
#	baseapp/baseapp.go
#	docs/docs/building-modules/01-module-manager.md
#	docs/docs/core/00-baseapp.md
#	testutil/mock/types_mock_appmodule.go
#	types/module/module.go
#	types/module/module_test.go
@mmsqe
apply fix cp
1c2fc7d
@mmsqe @julienrbrt
docs: update upgrade doc and changelog for MigrationModuleManager (co…
b807a92 
…smos#17373)

Co-authored-by: Julien Robert <[email protected]>
@mmsqe
replace with SetPreBeginBlocker
21467dc
@mmsqe
add noConsensusParams to ensure migration is done
7425437
@mmsqe
set app.deliverState.ctx
bacf6b8
@mmsqe
change to ConsensusParamsChanged
b57936f
@mmsqe
rm IsUpgradeModule
e227ea7
@mmsqe
pre-select PreBeginBlocker list
50617f7
@mmsqe
SetPreBeginBlocker before SetBeginBlocker
465f294
@mmsqe
fix lint
d162cd3
@mmsqe
fix test
8fe4dd5
@mmsqe
align err msg
93a314d
@mmsqe
fix doc
79edff3
@mmsqe
update doc
f4a5ccb
@mmsqe @yihuang
Update baseapp/abci.go
0f9b25a 
Co-authored-by: yihuang <[email protected]>
Signed-off-by: mmsqe <[email protected]>
@mmsqe
Apply suggestions from code review
6ed4e3e
@mmsqe @yihuang
Update baseapp/abci.go
d9918de 
Co-authored-by: yihuang <[email protected]>
Signed-off-by: mmsqe <[email protected]>
@mmsqe @yihuang
Apply suggestions from code review
a8393e2 
Co-authored-by: yihuang <[email protected]>
Signed-off-by: mmsqe <[email protected]>
@mmsqe @yihuang
Apply suggestions from code review
bd70c43 
Co-authored-by: yihuang <[email protected]>
Signed-off-by: mmsqe <[email protected]>
@mmsqe
prioritize upgrade preBlocker
e848e81
@mmsqe
Revert "prioritize upgrade preBlocker"
fe05fe6 
This reverts commit b6ae07f.
@mmsqe
rename
bc7dd17
@mmsqe
sync prioritize upgrade preBlocker
c187a6a
@mmsqe
reset gas meter after update cp
5b5211b
@mmsqe mmsqe merged commit b3af559 into release/v0.47.x Sep 5, 2023
1 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yihuang yihuang yihuang approved these changes

Assignees
No one assigned
Labels
C:x/upgrade
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmsqe @yihuang