-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: v0.47.x is outdated #193
Problem: v0.47.x is outdated #193
Conversation
…mos#17780) (cosmos#17793) Co-authored-by: Robert Zaremba <[email protected]> Co-authored-by: Julien Robert <[email protected]>
…s#17769) (cosmos#17848) Co-authored-by: Aleksandr Bezobchuk <[email protected]> Co-authored-by: Aleksandr Bezobchuk <[email protected]>
…17887) Co-authored-by: samricotta <[email protected]>
) Co-authored-by: Marko <[email protected]> Co-authored-by: Julien Robert <[email protected]>
Co-authored-by: Marko <[email protected]>
cosmos#17910) (cosmos#17916) Co-authored-by: Marko <[email protected]> Co-authored-by: Julien Robert <[email protected]>
@@ -223,7 +223,9 @@ | |||
// Implements types.KVStore. | |||
func (st *Store) Delete(key []byte) { | |||
defer telemetry.MeasureSince(time.Now(), "store", "iavl", "delete") | |||
st.tree.Remove(key) | |||
if _, _, err := st.tree.Remove(key); err != nil { | |||
panic(err) |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
@@ -144,6 +144,8 @@ | |||
// onWrite writes a KVStore operation to all of the WriteListeners | |||
func (s *Store) onWrite(delete bool, key, value []byte) { | |||
for _, l := range s.listeners { | |||
l.OnWrite(s.parentStoreKey, key, value, delete) | |||
if err := l.OnWrite(s.parentStoreKey, key, value, delete); err != nil { | |||
panic(err) |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
@@ -195,5 +195,7 @@ | |||
panic(errors.Wrap(err, "failed to write trace operation")) | |||
} | |||
|
|||
io.WriteString(w, "\n") | |||
if _, err = io.WriteString(w, "\n"); err != nil { | |||
panic(errors.Wrap(err, "failed to write newline")) |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
8fbcfbe
into
crypto-org-chain:release/v0.47.x
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change