Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: dependencies are outdated #533

Merged
merged 4 commits into from
Sep 30, 2024
Merged

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Sep 30, 2024

for more info: cometbft, sdk, ibc-go

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 46.45%. Comparing base (33e3cc6) to head (162f9df).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
server/start.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop     #533       +/-   ##
============================================
- Coverage    60.08%   46.45%   -13.64%     
============================================
  Files          128      181       +53     
  Lines         9844    14477     +4633     
============================================
+ Hits          5915     6725      +810     
- Misses        3345     7045     +3700     
- Partials       584      707      +123     
Files with missing lines Coverage Δ
app/app.go 76.24% <ø> (ø)
server/start.go 18.95% <0.00%> (ø)

... and 52 files with indirect coverage changes

@mmsqe mmsqe marked this pull request as ready for review September 30, 2024 02:33
@mmsqe mmsqe requested a review from yihuang September 30, 2024 02:33
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
pypi/[email protected] environment, eval, filesystem, network 0 3.67 MB ingy, nitzmahone, tinita

🚮 Removed packages: pypi/[email protected]

View full report↗︎

@mmsqe mmsqe enabled auto-merge (squash) September 30, 2024 02:48
@mmsqe mmsqe merged commit 5acb559 into crypto-org-chain:develop Sep 30, 2024
35 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants