Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: no way to disable nonce checking in benchmark (backport: #495) #541

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Oct 9, 2024

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.02%. Comparing base (5ed832f) to head (66097fb).
Report is 1 commits behind head on release/v0.22.x-cronos.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           release/v0.22.x-cronos     #541   +/-   ##
=======================================================
  Coverage                   64.01%   64.02%           
=======================================================
  Files                         130      130           
  Lines                        9788     9790    +2     
=======================================================
+ Hits                         6266     6268    +2     
  Misses                       3006     3006           
  Partials                      516      516           
Files with missing lines Coverage Δ
app/ante/eth.go 74.02% <100.00%> (+0.34%) ⬆️
app/ante/handler_options.go 83.33% <100.00%> (ø)

@mmsqe mmsqe requested a review from yihuang October 9, 2024 10:54
@mmsqe mmsqe merged commit 36adc9c into crypto-org-chain:release/v0.22.x-cronos Oct 10, 2024
29 of 30 checks passed
@yihuang yihuang deleted the release/v0.22.x-cronos_disable branch October 10, 2024 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants